Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp2049683pxu; Fri, 18 Dec 2020 04:26:28 -0800 (PST) X-Google-Smtp-Source: ABdhPJwu3yty47fA/mxoGLjI3GJNZv4ik5OUeJU576nPXhi4l7R/OwMKN8ckUOl6H5EnI5syKsET X-Received: by 2002:a17:906:bc9b:: with SMTP id lv27mr3665158ejb.505.1608294387819; Fri, 18 Dec 2020 04:26:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1608294387; cv=none; d=google.com; s=arc-20160816; b=HSHcVtpRDXhRZcNs2PBOTorWXkxzzmbOrH0smxqeNQPpkWzeJyOBKIgClTeW4ZQ9W/ V+ApMV9YAQGj6lhOFOKB+htJWAaevRn+pGsExZU3elyQs9mY/3Jpv+oXG7IUBwaI5/Ju eNY8E5peyfCL121LE3kJLXHT8xSgxrXpK8/aIP9L2LHk09kfXxqNcUTz79rnfNXOJdB+ E5S475vT6zQBV0WzM2IFDRJXJC2fBpqbXz0ym00rQoEcGz4BCJy161BxquZqk2LPFZL5 pUeP1GijvI0HrZQVq+zhjInw0FvEK2n0rHRWTe40YRuCIdvvrqscdc6defFt/cbR+nhj DvHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=I6Jc1yJjcNRC/skT3yP0vC8c2+p2pnxaOzpHPFUwwOA=; b=pK+3QJy4nLtXMwqkxy2HTEaWi2K9x7WiEPpqg8Kv+ul8pwlAavyMWSmBtV27A7KdtQ 1RHOnZx9szhnj22/q+hkfn2czUivhlJ1iJh0Z1WxsKuCFi9qzBYiFWb5HsJwMclyVGS2 CD2IXVOWPvVa7NrLjmD+ibxbz8/sPuQU3jja+7F2XvQ5FQYRzJhOKu7MJlCMOsH6HH5V bQwd3ONSpmy/qxibxLciKcGZCzxrB/aCvuVzmK4eBrxNI92l9Qs5SQyruMAlUywCEvlV CSukxgNWswUsnub8P6/faLHF8YiOwKY8/eTHCAlv/ftsZJbPpHLE9KajYC2u/hjWTtXJ LIbw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b="AOVmnq/O"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 92si6124897edm.533.2020.12.18.04.26.05; Fri, 18 Dec 2020 04:26:27 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b="AOVmnq/O"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726451AbgLRMSn (ORCPT + 99 others); Fri, 18 Dec 2020 07:18:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39836 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726441AbgLRMSm (ORCPT ); Fri, 18 Dec 2020 07:18:42 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 73838C0617A7 for ; Fri, 18 Dec 2020 04:18:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=I6Jc1yJjcNRC/skT3yP0vC8c2+p2pnxaOzpHPFUwwOA=; b=AOVmnq/OYugj7hrwBq6E0fUU+3 L46xEaZCG5ccilFMkBnAe6XgAx9OM7OiQc1G5CPSEoSkVOhIHaDDEvxDQNka9U1DqqYppcWO2u0NZ l7RAfbsLNHXW3fROkLTBSQttgh5nDLLaG5a1I8/372S15q7tHN6Pa/O2nQJ6JzRnMJRK76YVUclmv 1QK21mB7MgDSwO1MvlnvLaXDp02wspjb5OmHeOvP/SNc+izzMCwQzdmhXOD2fvgPeytyXnceNe33m jxaV21oVi9VKoJq/NocLl5yOdEfoMr9OE/lGB3l6T7lgBBW0w2sychLlufVVaLH1KEB9t40QIqx+z NA80GEdg==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kqEhk-00071q-Sa; Fri, 18 Dec 2020 12:17:52 +0000 Date: Fri, 18 Dec 2020 12:17:52 +0000 From: Matthew Wilcox To: Jacob Wen Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org Subject: Re: [PATCH] mm/vmscan: DRY cleanup for do_try_to_free_pages() Message-ID: <20201218121752.GK15600@casper.infradead.org> References: <20201218102217.186836-1-jian.w.wen@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201218102217.186836-1-jian.w.wen@oracle.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 18, 2020 at 06:22:17PM +0800, Jacob Wen wrote: > This patch reduces repetition of set_task_reclaim_state() around > do_try_to_free_pages(). what is a DRY cleanup?