Message-ID: <44FADE18.5040107@gentoo.org>
Date: Sun, 03 Sep 2006 09:52:24 -0400
From: Daniel Drake <dsd@gentoo.org>
User-Agent: Thunderbird 1.5.0.5 (X11/20060818)
MIME-Version: 1.0
To: Jeff Garzik <jeff@garzik.org>
CC: Andrew Morton <akpm@osdl.org>, sergio@sergiomb.no-ip.org,
       bjorn.helgaas@hp.com, linux-kernel@vger.kernel.org,
       Alan Cox <alan@lxorguk.ukuu.org.uk>, Chris Wedgwood <cw@f00f.org>,
       greg@kroah.com, harmon@ksu.edu, Len Brown <len.brown@intel.com>
Subject: Re: VIA IRQ quirk fixup only in XT-PIC mode Take 3
References: <1157330567.3046.24.camel@localhost.portugal> <20060903175841.7a84c63c.akpm@osdl.org> <44FBBD28.6070601@garzik.org>
In-Reply-To: <44FBBD28.6070601@garzik.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1217
Lines: 32

Jeff Garzik wrote:
> Andrew Morton wrote:
>> There's a similar patch in -mm: 
>> pci-quirk_via_irq-behaviour-change.patch. Does that work for you?
> 
> And then, we return to:
> 
> Some installations have VIA products on a PCI card.  We cannot assume 
> that all PCI_VENDOR_ID_VIA devices are on-board devices with the special 
> VIA PIC on-chip routing (the thing quirk_via_irq tweaks).

I'm not sure whether you are commenting on my patch 
(pci-quirk_via_irq-behaviour-change.patch), or Sergio's, but just to 
clarify:

My patch includes a hack that detects the presence of a VIA southbridge, 
and only applies quirks if a southbridge is present.

This isn't perfect, as someone could insert a VIA PCI card into a 
VIA-based motherboard and the PCI card would get quirked, but it's the 
most accurate solution which has been proposed so far.

If the southbridge detection hack is acceptable, there is no reason why 
it could not be combined with Sergio's patch.

Daniel

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/