Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp2164053pxu; Fri, 18 Dec 2020 07:01:40 -0800 (PST) X-Google-Smtp-Source: ABdhPJxecRH46rfopQVy+HH/8C1SxAgNVlcP7PZnm/zPnTnjIcV4PUo6mGa32PjeAUFQcK/q3zWg X-Received: by 2002:a1c:a9c8:: with SMTP id s191mr4607413wme.89.1608303700334; Fri, 18 Dec 2020 07:01:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1608303700; cv=none; d=google.com; s=arc-20160816; b=J8m7/Z01c+VoQ9IgYO5IWKLuoLx9AyPio3ekU57Fm7L4h3UA5o/PttWLGk/P/wdHsB 3jPh14oqVA/WG6cEU6AGWOzVYNJOkboS3UMMJ69QYy7pjfBgB+2KCfkFg/8NH4MA0NNP icmS4s70D4LDnOiGlcJ7tnUTvhPuYmtOVMAmza6KZpTCC0YTO6V4jRyTBcS0lDlo2P+V Wv1StFt+xmkJ5LlJH5Bd6WRabdfxT+5ruyzWLG23/jpGjx2MARHRwYCClOnN5rnIDtlV 6gyKrVja3zmWJkOs7xu/oDlOtWekLzers47KY75SS1JYF7PBGQZWDAEsb9DaaF2C1pwP oLYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:sender:dkim-signature; bh=btTFe9SQJ12UsM8X01XRMs1GCaQg0iWb0+ZNquj0Yho=; b=GOdDCdbwro3GUqVbMweHNTJolMoDQAfm12iZbHD9F5MLy6AVZBZNl26BKX+xxoREFk anYhYYl5+ErtJPakOqdxk/8SJ7adB5HXDhfmPWDLRYIdMEIctpBUf5dZ8kKOslv1NgcG I+V1rGuIj4zlMfq415trXqm7rIptYRmy3R4BtVPxvbZkaoz0x8KE1ICQGsB7GRvnlg2m 60TGd+ziO/xpGycMcNn4e2lH3FRP3edO6wvMIufcXhwD8zZoLzr8o8zZBZYf1iVzMPrd yJEC04Ss/TRJuUA8/R4Z54FVv3p2XV7Pq0z+rXMXJC+BgwIDEIfvwvxOPds5z39EnBhh Aj/g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=e4txPl7w; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b12si6811159edq.488.2020.12.18.07.01.15; Fri, 18 Dec 2020 07:01:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=e4txPl7w; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727437AbgLRPAY (ORCPT + 99 others); Fri, 18 Dec 2020 10:00:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36528 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726057AbgLRPAX (ORCPT ); Fri, 18 Dec 2020 10:00:23 -0500 Received: from mail-qk1-x734.google.com (mail-qk1-x734.google.com [IPv6:2607:f8b0:4864:20::734]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 72F1DC0617B0; Fri, 18 Dec 2020 06:59:43 -0800 (PST) Received: by mail-qk1-x734.google.com with SMTP id i67so2155089qkf.11; Fri, 18 Dec 2020 06:59:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=btTFe9SQJ12UsM8X01XRMs1GCaQg0iWb0+ZNquj0Yho=; b=e4txPl7w1XfT0AF9f9WIr694+OCREoNz2aoMqbtbBWuGj4WqmSno11qRfiOxyIYfAP pQOvE/5DaDl7dwc/TdNY3eGa1xUmxEz1rFlefvLY/wK1Zcg4S5jjtwsJj/sSuR1OxHqQ 8FgoQY7tq3utNH9sDFqGDURPi9fkjpoT5AvRmRLbWbW8Et2DUz/MEINM8z2ACRzDkK6y pUHyLLcWXdDeA/NnV/lx5G3v1Ld2x6fHThU1XRiYSeCSk5Sfr08p2HXHV48atgZrcaeJ MnxvomDQxBsudSzDpdeQ5FSyJQkcIKe5e/jChNMPiHBhQCpJof68XQgX0RADrRZcsOqU w2/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=btTFe9SQJ12UsM8X01XRMs1GCaQg0iWb0+ZNquj0Yho=; b=MfVY0D2K/n80FOGaYiiZcRyw6nXg3qH7WmTa8AyJlNxVrjzFWjeOMDdteCB/hoHA1d ZMf5AxBfj3IKckIj0o/Yu08ZTsIPPXptSJ9VE9g+wgDetkScI1XkDEFVqVK3NVy+dy3n 7l2XodkqPz/XkWc/314Zk3ixKHM5jQ4Wkb2qShtUDn6EzZliflPM7XJyHjKG8KodY2qz UVWjbOutziMMjVtqjUrpjtbO+HREkpb62dx6txGCB0aKn71pbOqjWgxm5luIoXJu+sif +x0iNFeI1biFhsINJmKCttVY8O23PZO60W/h+fME1han0S60qmPB5lrh2QWa/obWjBgV gqmA== X-Gm-Message-State: AOAM532rU+UN6PBJdMKVcQvKB9MIiKvnUQZwWmsYagrTBfzlKtEMhGe3 ktZBmal3+hcy2J43O0RTwGU= X-Received: by 2002:a05:620a:158e:: with SMTP id d14mr5001846qkk.358.1608303582534; Fri, 18 Dec 2020 06:59:42 -0800 (PST) Received: from localhost ([2600:380:bc52:ed25:f121:8f09:67ad:9838]) by smtp.gmail.com with ESMTPSA id d25sm5675018qkl.97.2020.12.18.06.59.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Dec 2020 06:59:41 -0800 (PST) Sender: Tejun Heo Date: Fri, 18 Dec 2020 09:59:07 -0500 From: Tejun Heo To: Ian Kent Cc: Fox Chen , Greg KH , akpm@linux-foundation.org, dhowells@redhat.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, miklos@szeredi.hu, ricklind@linux.vnet.ibm.com, sfr@canb.auug.org.au, viro@zeniv.linux.org.uk Subject: Re: [PATCH v2 0/6] kernfs: proposed locking and concurrency improvement Message-ID: References: <3e97846b52a46759c414bff855e49b07f0d908fc.camel@themaw.net> <67a3012a6a215001c8be9344aee1c99897ff8b7e.camel@themaw.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <67a3012a6a215001c8be9344aee1c99897ff8b7e.camel@themaw.net> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Fri, Dec 18, 2020 at 03:36:21PM +0800, Ian Kent wrote: > Sounds like your saying it would be ok to add a lock to the > attrs structure, am I correct? Yeah, adding a lock to attrs is a lot less of a problem and it looks like it's gonna have to be either that or hashed locks, which might actually make sense if we're worried about the size of attrs (I don't think we need to). Thanks. -- tejun