Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 18 Dec 2020 09:57:56 -0800
From:   Andrew Morton <akpm@linux-foundation.org>
To:     Souptick Joarder <jrdr.linux@gmail.com>
Cc:     Matthew Wilcox <willy@infradead.org>,
        Xiangyang Yu <yuxiangyang4@huawei.com>,
        Linux-MM <linux-mm@kvack.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/filemap: Fix warning: no previous prototype
Message-Id: <20201218095756.18d259ea243e434a8a90403a@linux-foundation.org>
In-Reply-To: <CAFqt6zYeDstXBHP+DCyBdmL4vDFBGekv7jrknU5c175sKVax4w@mail.gmail.com>
References: <20201217020311.491799-1-yuxiangyang4@huawei.com>
        <20201217022306.GB15600@casper.infradead.org>
        <CAFqt6zYeDstXBHP+DCyBdmL4vDFBGekv7jrknU5c175sKVax4w@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Fri, 18 Dec 2020 09:39:30 +0530 Souptick Joarder <jrdr.linux@gmail.com> wrote:

> On Thu, Dec 17, 2020 at 7:53 AM Matthew Wilcox <willy@infradead.org> wrote:
> >
> > On Thu, Dec 17, 2020 at 10:03:11AM +0800, Xiangyang Yu wrote:
> > > Fixed the warning when building with warnings enabled (W=1),
> > > This function is only used in filemap.c, so mark this function
> > > with 'static'.
> >
> > Good grief, no.  Look at the git history before proposing a patch.
> 
> revert "mm/filemap: add static for function __add_to_page_cache_locked"
> Revert commit 3351b16af494 ("mm/filemap: add static for function
> __add_to_page_cache_locked") due to incompatibility with
> ALLOW_ERROR_INJECTION which result in build errors.
> 

How about we add a prototype for __add_to_page_cache_locked() to squash
the warning, along with a comment explaining what's going on?