Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp2557922pxu; Fri, 18 Dec 2020 17:04:45 -0800 (PST) X-Google-Smtp-Source: ABdhPJyZ45+gY/Dmvb+zy3wJbaXwEvmeVaZJZzqaPSgcnbpayzqunZa5a4rjY4zXPxTpXMgp9uxA X-Received: by 2002:a05:6402:22e1:: with SMTP id dn1mr7053749edb.347.1608339884850; Fri, 18 Dec 2020 17:04:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1608339884; cv=none; d=google.com; s=arc-20160816; b=diytZYGo8RgSg2wyLIoogbZqNJN77q8BGt/wCt7RFnDTyJP35btyYeR5LcoQzGVGBx ufr8xs+GNvMMgucCZ23Rn0EtJ9lHgP2ij4XvNGniViazMf5MiZXBm15pVIeqmfe26djB +Beav76Ijiow49RHYCDP9b/caLEp9LrpBe/DAk7YCiIbTHMx4c4mHcyKE6L85a4zlihx dkmrf70HEQ8hVMEdIRc2FZJk1pOjlr0GxNH+RtkcEiEACssGSldJLRRekD2tTr6j5Q7E EIgcRLy1prT2DPNTd0DYm/rP4uDanRfY8/NfpxFGKeueHwaz/rBGyoeXa409+E/z9KPM yRMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=sDDCZaic67D42HvssAeVQLLFsX57yas9qVq21RheED0=; b=zXNXGiFeVt7Z3WpTfgp7ebQ6E31qFt9Gfa7Y5XxCV2cpGYOhiiSwxc6hcCIQJ3vBLr B3wD0rdsxb+TmxPhcbKsUEnfW26a0nU4B1jcVjTVR5GdDDcPCBpdiq0s9N/Gtj/Eb1Bk mEftlMSZdJ8cZStDly6+9sacnAxFfnpI8kldFmgyfYV4rpGP/taBkQrDwMlJiidyr71p VtvA5BbVlPGjwt01ay7CSdFlUG/aomOl6alqaptwV/BShnbPmB7Lry78c7g9H4+JPGfz JVgZZpShJ5EJHnrhbdorX9O3fbUkcgqMix+CJSjEuw/5fZ3BSJh+e731qwoUVsQCM5Zm q/Aw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c1si6612059edk.605.2020.12.18.17.04.22; Fri, 18 Dec 2020 17:04:44 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726311AbgLSBAv (ORCPT + 99 others); Fri, 18 Dec 2020 20:00:51 -0500 Received: from www262.sakura.ne.jp ([202.181.97.72]:56690 "EHLO www262.sakura.ne.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726053AbgLSBAv (ORCPT ); Fri, 18 Dec 2020 20:00:51 -0500 Received: from fsav304.sakura.ne.jp (fsav304.sakura.ne.jp [153.120.85.135]) by www262.sakura.ne.jp (8.15.2/8.15.2) with ESMTP id 0BJ108Mq021270; Sat, 19 Dec 2020 10:00:09 +0900 (JST) (envelope-from penguin-kernel@i-love.sakura.ne.jp) Received: from www262.sakura.ne.jp (202.181.97.72) by fsav304.sakura.ne.jp (F-Secure/fsigk_smtp/550/fsav304.sakura.ne.jp); Sat, 19 Dec 2020 10:00:08 +0900 (JST) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/fsav304.sakura.ne.jp) Received: from [192.168.1.9] (M106072142033.v4.enabler.ne.jp [106.72.142.33]) (authenticated bits=0) by www262.sakura.ne.jp (8.15.2/8.15.2) with ESMTPSA id 0BJ104SU021250 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NO); Sat, 19 Dec 2020 10:00:08 +0900 (JST) (envelope-from penguin-kernel@i-love.sakura.ne.jp) Subject: Re: WARNING: suspicious RCU usage in modeset_lock To: "Paul E. McKenney" Cc: Daniel Vetter , syzbot , Steven Rostedt , Josh Triplett , rcu@vger.kernel.org, Bartlomiej Zolnierkiewicz , dri-devel , Geert Uytterhoeven , "Gustavo A. R. Silva" , Linux Fbdev development list , Linux Kernel Mailing List , Nathan Chancellor , Peter Rosin , syzkaller-bugs , Dmitry Vyukov , Boqun Feng References: <000000000000cb6db205b68a971c@google.com> <20201216161621.GH2657@paulmck-ThinkPad-P72> <20201217152118.GR2657@paulmck-ThinkPad-P72> From: Tetsuo Handa Message-ID: Date: Sat, 19 Dec 2020 10:00:02 +0900 User-Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 16, 2020 at 5:16 PM Paul E. McKenney wrote: > In my experience, lockdep will indeed complain if an interrupt handler > returns while in an RCU read-side critical section. Can't we add lock status checks into the beginning and the end of interrupt handler functions (e.g. whether "struct task_struct"->lockdep_depth did not change) ?