Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965008AbWIDVw2 (ORCPT ); Mon, 4 Sep 2006 17:52:28 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965006AbWIDVw2 (ORCPT ); Mon, 4 Sep 2006 17:52:28 -0400 Received: from electric-eye.fr.zoreil.com ([213.41.134.224]:62175 "EHLO fr.zoreil.com") by vger.kernel.org with ESMTP id S965005AbWIDVw1 (ORCPT ); Mon, 4 Sep 2006 17:52:27 -0400 Date: Mon, 4 Sep 2006 23:49:45 +0200 From: Francois Romieu To: Arnd Bergmann Cc: Jan-Bernd Themann , netdev , Jeff Garzik , Christoph Raisch , Jan-Bernd Themann , linux-kernel , linux-ppc , Marcus Eder , Thomas Klein Subject: Re: [2.6.19 PATCH 1/7] ehea: interface to network stack Message-ID: <20060904214945.GA30804@electric-eye.fr.zoreil.com> References: <200609041237.46528.ossthema@de.ibm.com> <20060904201606.GA24386@electric-eye.fr.zoreil.com> <200609042311.21202.arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200609042311.21202.arnd@arndb.de> User-Agent: Mutt/1.4.2.1i X-Organisation: Land of Sunshine Inc. Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 770 Lines: 26 Arnd Bergmann : [...] > The driver should get merged as a single commit anyway, even > if split diffs are posted for review. Even if it gets merged > like this, bisect will work since the Kconfig option is added > in the final patch. I have seen/done worse but it's not exactly pretty. [...] > > > +?????int i; > > > > unsigned int ? > > does it matter? int as a counter is pretty standard. ppc64 takes unsigned int as a little optimization. I do not know how the target platform behaves here. -- Ueimor - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/