Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <1e0b6178033c064b99546d09b4b3ef9dda3cb1ad.camel@nxp.com>
Subject: Re: [PATCH 04/14] dt-bindings: display: bridge: Add i.MX8qm/qxp
 pixel combiner binding
From:   Liu Ying <victor.liu@nxp.com>
To:     Rob Herring <robh@kernel.org>
Cc:     dri-devel <dri-devel@lists.freedesktop.org>,
        Jernej Skrabec <jernej.skrabec@siol.net>,
        Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
        Andrzej Hajda <a.hajda@samsung.com>, Vinod <vkoul@kernel.org>,
        Linux Media Mailing List <linux-media@vger.kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        David Airlie <airlied@linux.ie>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        devicetree@vger.kernel.org, Sascha Hauer <kernel@pengutronix.de>,
        Jonas Karlman <jonas@kwiboo.se>,
        Fabio Estevam <festevam@gmail.com>,
        Neil Armstrong <narmstrong@baylibre.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        Shawn Guo <shawnguo@kernel.org>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
        NXP Linux Team <linux-imx@nxp.com>,
        Kishon Vijay Abraham I <kishon@ti.com>
Date:   Sat, 19 Dec 2020 12:15:10 +0800
In-Reply-To: <CAL_JsqLcyUJWt_gc3B01C0Y+NC61ucYNA8j1jnxTs8U1kudM=Q@mail.gmail.com>
References: <1608199173-28760-1-git-send-email-victor.liu@nxp.com>
         <1608199173-28760-5-git-send-email-victor.liu@nxp.com>
         <1608231036.357497.50647.nullmailer@robh.at.kernel.org>
         <e2edc2e37b6905fd19ada4c212338c6978200fa5.camel@nxp.com>
         <CAL_JsqLcyUJWt_gc3B01C0Y+NC61ucYNA8j1jnxTs8U1kudM=Q@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from vbox (116.232.209.249) by HK2PR0302CA0019.apcprd03.prod.outlook.com (2603:1096:202::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3700.19 via Frontend Transport; Sat, 19 Dec 2020 04:15:36 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: b278fb3b-26c2-4676-c5eb-08d8a3d4c1e5
X-MS-TrafficTypeDiagnostic: AM7PR04MB6776:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <AM7PR04MB67764A61A37CB58DA25F0CDF98C20@AM7PR04MB6776.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: TtJajdfEnS3woZZbB4yOd/AggZD/iOxm4eUB0bF4jQ10nn7c1tf6+rYimz0sfFXkrU779qcB6jUrYxQWsots+6FAeBy/bdF4f1B862P3sjeyCvfRBhiBxtpUaijr9itRtn5hWEl2qT4tpagfUoPD5+a8/UDa0iEEjxKiQ4K4n7TRA5J0FLevHATB2QVQe76udVO9yePFlzIxAcSRjX+OGdMgjdNtBNZGlTkADSHl+z+Mv9ZD8wYitJvL8IW79XMKgmE3nfNmLX4L2FFZWbrX6khb4SAO4ETESBMCBHvBfMGzvcLC4cdDEvxDTfqRQIxv/wNUYJNZB7+OGQYrwtY0PY53or5twzGHUOg8xpem2g4u2knPhbsU9bVYWkUwAJk5ZEbywGXYqNupROrfvoUxji/nBrInO/WJ4pakLMokj9OefBq3IqoG5IvwfEkyjRdL+SU7w3tm2ZADngXnu3Q7VASYUmnH/ewOdrnpvCuQlg/M4I9gjwDlv+83ocGgLMmnQb9WM4vXZKHdacNVffTn+g==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB3974.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39850400004)(136003)(346002)(376002)(366004)(396003)(2906002)(4326008)(966005)(45080400002)(6916009)(478600001)(6496006)(316002)(54906003)(4001150100001)(36756003)(186003)(26005)(6666004)(16526019)(66556008)(2616005)(8936002)(52116002)(956004)(83380400001)(6486002)(66946007)(66476007)(86362001)(8676002)(53546011)(5660300002)(7416002)(99106002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?bnRBaEVodUtCQ09PZ0VzVE43YXVaRHllTW9hb014UGw5aC9lZWNKcWJNbERI?=
 =?utf-8?B?cnJRZnVxekVRWVlpWlpaS3FkMi9ObVFSMkdvZnV4QW5SaEFiNE5UWFY5b0Fu?=
 =?utf-8?B?bkRDalBMWjdzQmtEdmR5TWJYQS92b1NtTWtqRlFRWWNuOGcvT01iN2tyc2Fx?=
 =?utf-8?B?bE9pUWM0dVdGL3lTSTNyT2lHbkd6L1dHdUhVVGI3RnJsa253dzdnOHZTQito?=
 =?utf-8?B?UDd2VHVSQ1BMN3UwV2RDQklJcEc4d203aW1ZNjBPYmVLd2hGMlJycWpCNFJv?=
 =?utf-8?B?Q3haWHhxU1JFTXpUdENhT3FBcWNPeXRXa09JRVlST0FGeXJpNldyQnMrSjhX?=
 =?utf-8?B?Z2w5S1REMXF5NTlPU09vdFZsVk5HRmdqVDhMZjVoTXUzWlBqNkNyY2JjeWsx?=
 =?utf-8?B?K1BTcVhiNGFveTRYa2s4bHpHNUlOYWFOc2Z3UGM2QkdzQVpoSWdMNWpxalNr?=
 =?utf-8?B?RmRhQksvbGhYditRakZHbVJZdFk4M0tvVjRzM0Z2anBmTDQ1a2ZOZlhrSFoy?=
 =?utf-8?B?a0lha2ROT2JEZWZ1VUlGeWNsVGh6ZGdqU1E2Q1MrclZXTWtJbTlleVJidmxW?=
 =?utf-8?B?eUlxcFQ0MEY0M0t5cExCU1dGeTIzbW9mUWZCeHJuRG5JOEQ3SU5VNWVKNE1q?=
 =?utf-8?B?NG11R09uSkZzekQ1UUFwWGhURUY4dmVvVWR4emRPYlpHd1JQTXVpTnZ2ME9p?=
 =?utf-8?B?UEFJSENML1JETFd5eUVXTFdwM2M5THg5Vk9LVFYxRDRrOU9QVzcyYlZxRGNi?=
 =?utf-8?B?aWdCRllHVkFrZktkMStyMStPSVEzRUN2bVU1YXhXYmtFc2JVY2VVMEYyUmcy?=
 =?utf-8?B?eUdzNlNSeGhjOFozMTFMRlhkcDlYMnJReVZsRFcwbkdFb3h2bk9hdmwrYjFF?=
 =?utf-8?B?YVcyRXJscjhPZ0tJYTJ4djYxTHFtc3FkU1liOEpWMlV6QmluakljNzc1dXhO?=
 =?utf-8?B?MThhQWprY2FTQmd3VFNCVTFpNS9rckdKbnN1NXJDdFlreEZFS3R3Q3dOV3o4?=
 =?utf-8?B?ZDNKbzQyWUlBSUhjVGo5cEZ2SmdhNHlNcVozcFl0TzdvTzlGL1BOaC9aanln?=
 =?utf-8?B?ZHNNdW9BaVprVUpYak9uRU1rRXZWL3ZwVTVQaUw0OW51cGtoc01oWHczM1pw?=
 =?utf-8?B?cWM1K2l6Rjd4RHBwMExiU2V5VTAzOVN3c0lUV3VWcGF4enMrZGdabjdmTU1H?=
 =?utf-8?B?UVkwMmZaOFpUN0lPVGcvM2RyZjFkWHcrTjhvWkQ0ZEhacFc4MWRVVnhmRXNr?=
 =?utf-8?B?aTg1MFdZV1pOL2RtMFZsaGo0eWZqMjliVFczWkY0WEZqOC9LbitQaFVmNTBV?=
 =?utf-8?Q?hlzqj82C2PeQTtvbUfABBigbW2MomKvzlv?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB3974.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Dec 2020 04:15:45.3311
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-Network-Message-Id: b278fb3b-26c2-4676-c5eb-08d8a3d4c1e5
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: x8gczFkG/PgG85cqj+EFqobpxgkdXVYcIK/WFawhI4SlSQ9QagIrsWO9yHPErxXqPRRCrzfzf2RUz903BYR17Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6776
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

On Fri, 2020-12-18 at 16:42 -0600, Rob Herring wrote:
> On Thu, Dec 17, 2020 at 7:48 PM Liu Ying <victor.liu@nxp.com> wrote:
> > 
> > Hi,
> > 
> > On Thu, 2020-12-17 at 12:50 -0600, Rob Herring wrote:
> > > On Thu, 17 Dec 2020 17:59:23 +0800, Liu Ying wrote:
> > > > This patch adds bindings for i.MX8qm/qxp pixel combiner.
> > > > 
> > > > Signed-off-by: Liu Ying <victor.liu@nxp.com>
> > > > ---
> > > >  .../display/bridge/fsl,imx8qxp-pixel-combiner.yaml | 160
> > > > +++++++++++++++++++++
> > > >  1 file changed, 160 insertions(+)
> > > >  create mode 100644
> > > > Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-
> > > > pixel-combiner.yaml
> > > > 
> > > 
> > > My bot found errors running 'make dt_binding_check' on your
> > > patch:
> > > 
> > > yamllint warnings/errors:
> > > 
> > > dtschema/dtc warnings/errors:
> > > Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-
> > > pixel-combiner.example.dts:19:18: fatal error: dt-
> > > bindings/clock/imx8-lpcg.h: No such file or directory
> > >    19 |         #include <dt-bindings/clock/imx8-lpcg.h>
> > >       |                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > > compilation terminated.
> > > make[1]: *** [scripts/Makefile.lib:342:
> > > Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-
> > > pixel-combiner.example.dt.yaml] Error 1
> > > make[1]: *** Waiting for unfinished jobs....
> > > make: *** [Makefile:1364: dt_binding_check] Error 2
> > > 
> > > See 
> > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.ozlabs.org%2Fpatch%2F1417599&amp;data=04%7C01%7Cvictor.liu%40nxp.com%7C96806e0ce6bc40c936fa08d8a3a64551%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637439281816690986%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=Cjyszb0alRE5z2OGKdZZEg5PQpH11U%2BGqVt6couCLGE%3D&amp;reserved=0
> > > 
> > > This check can fail if there are any dependencies. The base for a
> > > patch
> > > series is generally the most recent rc1.
> > 
> > This series can be applied to linux-next/master branch.
> 
> I can't know that to apply and run checks automatically. I guessed
> that reviewing this before sending, but I want it abundantly clear
> what the result of applying this might be and it wasn't mentioned in
> this patch.
> 
> Plus linux-next is a base no one can apply patches to, so should you
> be sending patches based on it? It's also the merge window, so maybe

I sent this series based on drm-misc-next.  This series is applicable
to linux-next/master, and may pass 'make dt_binding_check' there.

I'll mention dependencies in the future where similar situations
appear. Thanks.

BTW, does it make sense for the bot to additionaly try linux-next if
needed?  Maybe, that'll be helpful?

Regards,
Liu Ying

> wait until rc1 when your dependency is in and the patch can actually
> be applied. Also, the drm-misc folks will still need to know they
> need
> to merge rc1 in before this is applied.
> 
> Rob