Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp2724612pxu; Fri, 18 Dec 2020 23:54:37 -0800 (PST) X-Google-Smtp-Source: ABdhPJy54h52BnkBprl8pEgXQLIVh5y/ifiriseJMFPqHxGgCNuiBxrYGzlo4USouZSo/wH6MMfQ X-Received: by 2002:aa7:c749:: with SMTP id c9mr7991168eds.3.1608364477014; Fri, 18 Dec 2020 23:54:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1608364477; cv=none; d=google.com; s=arc-20160816; b=dnKIFEGWdbblkps8c0sZAF9UL3noHMyANq0zNZIfXAqyG18pHON+6B0e2mCUvkMhOO /EJTz5dcmNJQlgMDBrWUvyc7mMprw7QejA2wNi1elyRc9ALOLgr9OP4Dpq+OycFh/zFm 7WsGmJRlSrm6wP+Fj9SXHmqgLmD3Kuibm7op/xnJ0qWcTmxt7Vce1rVy7NplemSsCstS 1WUlLaRCJ10xXt2ediRlly0zg5D7e/9O9cP7Yik2QYUn6LTe8vYIY1NW2OGCElGhHivs fhT9Ye5GtxH8z85ZZYP3mldMJyhLVeY0yJJF+/N+0y/3SbzovxacYKsqbKWOwF9utZPn /b1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:dkim-signature:date; bh=JSat8h/R4FQQlkMmeZA9NIljYy+M/aRTmqGwmEKZ/90=; b=PtOYdtAN3TQP7xX3WgtYw4F5ENY5pnfXGqaMBEZ6D61OfHrZyPE83+IqRF7RBTUpLC uFEGMwh/E1AW4LKdgPX5g4VGbwFi1j34lY3vBL9SC+T1Y1QjVIKbIQmSXwrxZlkhw8u+ CaOaDqeQyosxHdfz1R+JlPFE6AELxonzj0sf3OWtyI8a/Cg+Nws7F1y/bZD1a6xZB78Y +VJM8HcxLY1APgWlOY7xDMi99A+LJv4DA6LnYhRiw+EJUDukUBddwUbE6zhQCtd+5y1u 8O8QbgPXztL1zhYs9h8wCwkQJ+9a/qLbcjD8o9lLmfWciCADEChgYfRsCsLxMVAILF1D Dy1g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=qiTPukJ6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j24si5758897ejs.60.2020.12.18.23.54.14; Fri, 18 Dec 2020 23:54:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=qiTPukJ6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726479AbgLSHws (ORCPT + 99 others); Sat, 19 Dec 2020 02:52:48 -0500 Received: from mail.kernel.org ([198.145.29.99]:49010 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726364AbgLSHwr (ORCPT ); Sat, 19 Dec 2020 02:52:47 -0500 Date: Sat, 19 Dec 2020 08:52:03 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1608364327; bh=LosQleLwVUVFjt5QY+Uyi+t7QKCQXWEOOOe/fukzRmk=; h=From:To:Cc:Subject:References:In-Reply-To:From; b=qiTPukJ6AGxGHuIMkJMTlssLWL6yyGr7J+NfD96qy+Twnl6c2vp/wdDz2Ohl11/5U Ab1uWhoXQ46O/oDGkzKeV3TrcTQvLa+fzhYpA+o0PmfRJluAnRkrt51q6kfawRl2wZ 2uT+RYAFFhTjT7BUN2TPiOzxAPmTNGv8DQXuDaEg= From: Greg KH To: Daejun Park Cc: "avri.altman@wdc.com" , "jejb@linux.ibm.com" , "martin.petersen@oracle.com" , "asutoshd@codeaurora.org" , "stanley.chu@mediatek.com" , "cang@codeaurora.org" , "huobean@gmail.com" , "bvanassche@acm.org" , ALIM AKHTAR , "linux-scsi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Sung-Jun Park , yongmyung lee , Jinyoung CHOI , Adel Choi , BoRam Shin , SEUNGUK SHIN Subject: Re: [PATCH v15 1/3] scsi: ufs: Introduce HPB feature Message-ID: References: <20201219032952epcms2p668a76f6b5ab021f0e66c856c44d5be0d@epcms2p6> <20201219033039epcms2p849fa40807c1a10934a57a0c28fc356be@epcms2p8> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201219033039epcms2p849fa40807c1a10934a57a0c28fc356be@epcms2p8> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Dec 19, 2020 at 12:30:39PM +0900, Daejun Park wrote: > @@ -323,6 +325,8 @@ static struct attribute *ufs_sysfs_device_descriptor[] = { > &dev_attr_number_of_secure_wpa.attr, > &dev_attr_psa_max_data_size.attr, > &dev_attr_psa_state_timeout.attr, > + &dev_attr_hpb_version.attr, > + &dev_attr_hpb_control.attr, > &dev_attr_ext_feature_sup.attr, > &dev_attr_wb_presv_us_en.attr, > &dev_attr_wb_type.attr, I thought I said this before, but you are adding new sysfs files, with no Documentation/ABI/ update which is not allowed. Please fix up. thanks, greg k-h