Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Mime-Version: 1.0
Subject: RE: Re: [PATCH v15 1/3] scsi: ufs: Introduce HPB feature
Reply-To: daejun7.park@samsung.com
Sender: Daejun Park <daejun7.park@samsung.com>
From:   Daejun Park <daejun7.park@samsung.com>
To:     Greg KH <gregkh@linuxfoundation.org>,
        Daejun Park <daejun7.park@samsung.com>
CC:     "avri.altman@wdc.com" <avri.altman@wdc.com>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
        "stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
        "cang@codeaurora.org" <cang@codeaurora.org>,
        "huobean@gmail.com" <huobean@gmail.com>,
        "bvanassche@acm.org" <bvanassche@acm.org>,
        ALIM AKHTAR <alim.akhtar@samsung.com>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Sung-Jun Park <sungjun07.park@samsung.com>,
        yongmyung lee <ymhungry.lee@samsung.com>,
        Jinyoung CHOI <j-young.choi@samsung.com>,
        Adel Choi <adel.choi@samsung.com>,
        BoRam Shin <boram.shin@samsung.com>,
        SEUNGUK SHIN <seunguk.shin@samsung.com>
In-Reply-To: <X92xI1Atgcd7z8e0@kroah.com>
Message-ID: <20201219090328epcms2p8d8b989962c118a9be983286e625b323e@epcms2p8>
Date:   Sat, 19 Dec 2020 18:03:28 +0900
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 102P
DLP-Filter: Pass
References: <X92xI1Atgcd7z8e0@kroah.com>
        <20201219032952epcms2p668a76f6b5ab021f0e66c856c44d5be0d@epcms2p6>
        <20201219033039epcms2p849fa40807c1a10934a57a0c28fc356be@epcms2p8>
        <CGME20201219032952epcms2p668a76f6b5ab021f0e66c856c44d5be0d@epcms2p8>
Precedence: bulk

On Sat, Dec 19, 2020 at 12:30:39PM +0900, Daejun Park wrote:
> > @@ -323,6 +325,8 @@ static struct attribute *ufs_sysfs_device_descriptor[] = {
> >  	&dev_attr_number_of_secure_wpa.attr,
> >  	&dev_attr_psa_max_data_size.attr,
> >  	&dev_attr_psa_state_timeout.attr,
> > +	&dev_attr_hpb_version.attr,
> > +	&dev_attr_hpb_control.attr,
> >  	&dev_attr_ext_feature_sup.attr,
> >  	&dev_attr_wb_presv_us_en.attr,
> >  	&dev_attr_wb_type.attr,
> 
> I thought I said this before, but you are adding new sysfs files, with
> no Documentation/ABI/ update which is not allowed.

You're right, I fixed this on patch v14. But I dropped documentation on this patch.
I will resubmit patch.

Thanks,
Daejun