Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: vOOXgB1YYRQ9DNNhNC2hxFEZ1FvGi6nm7htOW/KImcp1WqQoQi6QKLdyEUjPM65D2ZTMpY9bng
 Tu0Eex+/KH3tetWMSfC0PYc05WZc+g1CpGnP9LgCrf8A/2ED6OvpRcMd+aekA+ogjIMSsJDJdD
 nQaMAEqGgvUcwVaQsaeI68VmC9vLzqK0giDBUceIG6tfk5dFcVlB9UCUgLh4SJriKKRntDXuYJ
 PojlAb0GjxCuRj7O5H/cXtClOIw0EyJAhhzFYMk48frgA8aLnfDXRTXPqEjmBj5fJy5Qnm6xTW
 CW4=
From:   Avri Altman <Avri.Altman@wdc.com>
To:     Greg KH <gregkh@linuxfoundation.org>,
        Daejun Park <daejun7.park@samsung.com>
CC:     "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
        "stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
        "cang@codeaurora.org" <cang@codeaurora.org>,
        "huobean@gmail.com" <huobean@gmail.com>,
        "bvanassche@acm.org" <bvanassche@acm.org>,
        ALIM AKHTAR <alim.akhtar@samsung.com>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Sung-Jun Park <sungjun07.park@samsung.com>,
        yongmyung lee <ymhungry.lee@samsung.com>,
        Jinyoung CHOI <j-young.choi@samsung.com>,
        Adel Choi <adel.choi@samsung.com>,
        BoRam Shin <boram.shin@samsung.com>,
        SEUNGUK SHIN <seunguk.shin@samsung.com>
Subject: RE: [PATCH v16 1/3] scsi: ufs: Introduce HPB feature
Thread-Topic: [PATCH v16 1/3] scsi: ufs: Introduce HPB feature
Thread-Index: AQHW1ef8ia5Se8hQe0WKINuS/BY2sqn+OdsAgAAi5AA=
Date:   Sat, 19 Dec 2020 12:48:31 +0000
Message-ID: <DM6PR04MB6575AC2A541FCAAB60E581FBFCC20@DM6PR04MB6575.namprd04.prod.outlook.com>
References: <20201219091802epcms2p2c86f7ae2e81aa015702572a8ef180dae@epcms2p2>
 <CGME20201219091802epcms2p2c86f7ae2e81aa015702572a8ef180dae@epcms2p7>
 <20201219091847epcms2p7afeebd03c47eed0b65f89375a881233e@epcms2p7>
 <X93XuJ4lsQbBgnU+@kroah.com>
In-Reply-To: <X93XuJ4lsQbBgnU+@kroah.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 6ee47110-1e18-47a4-8d58-08d8a41c63ca
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Dec 2020 12:48:31.2008
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 2qR3NoXNgOU0KdHd4dUhRcWQrP+LQjESav0fiu5Whwi3ak0bf45CoKjrI57n4H2bDty8bEYbec+HDQGhf+f/FQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR04MB4027
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>=20
>=20
> On Sat, Dec 19, 2020 at 06:18:47PM +0900, Daejun Park wrote:
> > +static int ufshpb_get_state(struct ufshpb_lu *hpb)
> > +{
> > +     return atomic_read(&hpb->hpb_state);
> > +}
> > +
> > +static void ufshpb_set_state(struct ufshpb_lu *hpb, int state)
> > +{
> > +     atomic_set(&hpb->hpb_state, state);
> > +}
>=20
> You have a lock for the state, and yet the state is an atomic variable
> and you do not use the lock here at all.  You don't use the lock at all
> infact...
>=20
> So either the lock needs to be dropped, or you need to use the lock and
> make the state a normal variable please.
hpb_state_lock is mainly protecting the list of active regions.
Just grep  lh_lru_rgn in patch 2/3.

Thanks,
Avri