Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: Guenter Roeck <groeck7@gmail.com>
Date:   Sat, 19 Dec 2020 09:51:51 -0800
From:   Guenter Roeck <linux@roeck-us.net>
To:     Kalesh Singh <kaleshsingh@google.com>
Cc:     surenb@google.com, minchan@kernel.org, joelaf@google.com,
        lokeshgidra@google.com, kernel-team@android.com,
        Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: mremap - Fix extent calculation
Message-ID: <20201219175151.GA6542@roeck-us.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk

On Sat, Dec 19, 2020 at 05:04:33PM +0000, Kalesh Singh wrote:
> When `next < old_addr`, `next - old_addr` arithmetic underflows
> causing `extent` to be incorrect.
> 
> Make `extent` the smaller of `next - old_addr` or `old_end - old_addr`.
> 
> Reported-by: Guenter Roeck <linux@roeck-us.net>
> Signed-off-by: Kalesh Singh <kaleshsingh@google.com>

This patch fixes the problem I had observed when booting 'parisc'
images.

Tested-by: Guenter Roeck <linux@roeck-us.net>

Guenter

> ---
>  mm/mremap.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/mm/mremap.c b/mm/mremap.c
> index c5590afe7165..f554320281cc 100644
> --- a/mm/mremap.c
> +++ b/mm/mremap.c
> @@ -358,7 +358,9 @@ static unsigned long get_extent(enum pgt_entry entry, unsigned long old_addr,
>  
>  	next = (old_addr + size) & mask;
>  	/* even if next overflowed, extent below will be ok */
> -	extent = (next > old_end) ? old_end - old_addr : next - old_addr;
> +	extent = next - old_addr;
> +	if (extent > old_end - old_addr)
> +		extent = old_end - old_addr;
>  	next = (new_addr + size) & mask;
>  	if (extent > next - new_addr)
>  		extent = next - new_addr;
> -- 
> 2.29.2.729.g45daf8777d-goog
>