Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201219125344.671832095@linuxfoundation.org> <20201219125345.376925474@linuxfoundation.org>
 <20201219215139.GA29536@amd>
In-Reply-To: <20201219215139.GA29536@amd>
From:   Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Date:   Sat, 19 Dec 2020 23:38:25 +0100
Message-ID: <CAFBinCBRe3Oacqce1EDQpoNmEhXeUxJrA43RTA0+_fVciDJzhg@mail.gmail.com>
Subject: Re: [PATCH 5.9 14/49] net: stmmac: dwmac-meson8b: fix mask definition
 of the m250_sel mux
To:     Pavel Machek <pavel@ucw.cz>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        Jerome Brunet <jbrunet@baylibre.com>,
        Jakub Kicinski <kuba@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Pavel,

On Sat, Dec 19, 2020 at 10:51 PM Pavel Machek <pavel@ucw.cz> wrote:
[...]
> I can't say I like this one:
>
>
> >       clk_configs->m250_mux.reg = dwmac->regs + PRG_ETH0;
> > -     clk_configs->m250_mux.shift = PRG_ETH0_CLK_M250_SEL_SHIFT;
> > -     clk_configs->m250_mux.mask = PRG_ETH0_CLK_M250_SEL_MASK;
> > +     clk_configs->m250_mux.shift = __ffs(PRG_ETH0_CLK_M250_SEL_MASK);
>
> It replaces constant with computation done at runtime; compiler can't
> optimize it as __ffs is implemented with asm().
what do you suggest to use instead?
personally I don't see a problem because this is only called once at
driver probe time.


Best regards,
Martin