Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp3569877pxu; Sun, 20 Dec 2020 07:27:12 -0800 (PST) X-Google-Smtp-Source: ABdhPJyPfAZRyPOuzm0ttkSQSjhvBoVKRJH/eurEAOD2k4qyOPUV/NagsH90w+v542Br117eooyC X-Received: by 2002:a05:6402:2070:: with SMTP id bd16mr12314271edb.107.1608478031900; Sun, 20 Dec 2020 07:27:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1608478031; cv=none; d=google.com; s=arc-20160816; b=WmXZm2GFQdX2iwSBfoYvrUVwG0X/VY/eMl6HUxYrrVbAn6bMqB5jNbcZn9UyiQu1+M a7CY/Tpk4A6FaXSNXwAgwvCmAasQ5Mzgnk5s3Jn69Gq4J/f1bFy7ioNJVGu6SA/jows+ xM6X8b0G5+itXgavmstPiPvvyU+6gf6hntT1Sw5f8HrzrpYx8LFWRTFL//87UBIWNxyK MWWMiTBz430DFkqI1Fcamzvjih5KwhD+5BMw4XOqACgXN8eQif+evoizVbPtBwxeN4AF lp1nHjI+xbi5tfBWCbSrD7IBfrURAzuqRTFH5xjDQH95gKm21KakQzYtj1CTzep1UM8a tktw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=ENt0nECCuhJeVj2MHqVhDtRr2FgvD9xasI9b00Elhnk=; b=bGddQY89ywICZyQjHMvOV3SlOmYgFsl5U+PObMNl0r0p1hIoCyC+PjesKzF4K1x2fv lOcFlIfiz953nua4I1/mGk2MyoyijVgBvmmESnBHKOd3tzcYrvMrsyzMYT6EB8tpwdhZ fJ1UJh6/BfmK/qXcImYMk8X32aKo3XpsPy73ApOFAkShMA6lRco1KrXDKTAikZ2VxGIt Q/bnNjZKj0Ct13N5yrFeabxaqWyWewk2vAybY/MeLfIoK/WxJzssNikFr7z4r74VcAvd R01cB91aw6sXVEeRGqAOaRovkF+k7QUHLoYlItalQ9HDMJcqaeXpdF4IeRY61SIeoESW ixWw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k7si2649042ejb.442.2020.12.20.07.26.49; Sun, 20 Dec 2020 07:27:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727641AbgLTP0W (ORCPT + 99 others); Sun, 20 Dec 2020 10:26:22 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:56598 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727495AbgLTP0V (ORCPT ); Sun, 20 Dec 2020 10:26:21 -0500 Received: from ip5f5af0a0.dynamic.kabel-deutschland.de ([95.90.240.160] helo=wittgenstein) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1kr0aX-0004u0-IK; Sun, 20 Dec 2020 15:25:37 +0000 Date: Sun, 20 Dec 2020 16:25:35 +0100 From: Christian Brauner To: Leesoo Ahn Cc: linux-kernel@vger.kernel.org, Leesoo Ahn , "Eric W. Biederman" , Oleg Nesterov , Jens Axboe , Peter Collingbourne , Zhiqiang Liu Subject: Re: [PATCH] signal: Don't init struct kernel_siginfo fields to zero again Message-ID: <20201220152535.k74foxjgejedslgx@wittgenstein> References: <20201220074555.12655-1-lsahn@ooseel.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20201220074555.12655-1-lsahn@ooseel.net> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Dec 20, 2020 at 04:45:54PM +0900, Leesoo Ahn wrote: > clear_siginfo() is responsible for clearing struct kernel_siginfo object. > It's obvious that manually initializing those fields is needless as > a commit[1] explains why the function introduced and its guarantee that > all bits in the struct are cleared after it. > > [1]: commit 8c5dbf2ae00b ("signal: Introduce clear_siginfo") > > Signed-off-by: Leesoo Ahn > --- Acked-by: Christian Brauner I have a __user annotation fix in my tree from Jann that I plan to send soon so I'll just stick this on top of it if noone minds. Christian