Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp3572086pxu; Sun, 20 Dec 2020 07:31:29 -0800 (PST) X-Google-Smtp-Source: ABdhPJw53rQn9I9De5V3ICD9k2Ab170JjUm+ZiZedO5wtaiuAxqAMzCTiNdCEY1NbLU2DvgGXHSv X-Received: by 2002:a05:6402:ca1:: with SMTP id cn1mr12752251edb.128.1608478288848; Sun, 20 Dec 2020 07:31:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1608478288; cv=none; d=google.com; s=arc-20160816; b=FDWUvRnH0ADX1YWw51cQLgxM8TWRv3MdpiqWyZakLcT+26VWx5L7+cihI9MljThrDC oHhoxqJ6gCQWrYw7jSchzPkNgspaz+VzOYhVTMFcVPlAPpV+vmYoXY19JhoeAgJFuI8V t4HUUFCEOOwLOpy8HEmXawIttym0dS6rP0Tnxnm/sprxhrXdHL6Uv+liJIYhizK0d6BL s+RXvG7Fq5TN1VuYVmQRsWL4Fbmx3wAGNVpb+QVJN/HqfYmuceXwGLdAucZASeI9U6TL mo2Jer8CQOt/WvZZuHEmRvroWfEkMV5V9+tEeucPUT1IAjTS/eyEzrvJaMdm7TYy8A1O vNJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=p5NOTE254vm73Lsu62t4gF2fTVdlTH1aZ94SNqxQ8GA=; b=CaZLHi51mlI7nPetisk7VcbmAbP7QcSEl8+BTKX5cWgLddXVnGIP20EdvpvMwJb16N VvsT7NGofcbxL+ht6ewZH8vWklpCortoq6H1GFW/hUGxNdl3yBl85bXkNp+/Y3ZSyD4V u8EwtnKs1XKrtguYytlgALFDKmvG1xGYV9L1VX0JqwhPbmnzWJ+zk/ngnYP/IocY2Mvd w2mBux+0LwvHLqHWc29kMd+nY5hnxKw6j+1KXguax+vVQiP7xlW9SuCUWI4Jipg42Snd 50T4qOXselotzePlcVl9dWVC6lHtTclQC3UphoGpQBGQNtQwVIg5xZoY3DoIMmQ3jJPB 27iA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=D8tXd1I+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k7si2649042ejb.442.2020.12.20.07.31.06; Sun, 20 Dec 2020 07:31:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=D8tXd1I+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727700AbgLTPaS (ORCPT + 99 others); Sun, 20 Dec 2020 10:30:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57168 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725974AbgLTPaR (ORCPT ); Sun, 20 Dec 2020 10:30:17 -0500 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 888F2C0617B0 for ; Sun, 20 Dec 2020 07:29:25 -0800 (PST) Received: by mail-lf1-x136.google.com with SMTP id o13so17732155lfr.3 for ; Sun, 20 Dec 2020 07:29:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=p5NOTE254vm73Lsu62t4gF2fTVdlTH1aZ94SNqxQ8GA=; b=D8tXd1I+MQFSuLn4t1MdD78KrSSBwywZmReYQRhr2ieSTwOLazBjAYdmCiRljQYzdU Da87xyaFugXVyyJPf+iIOZBJ6IzAr6jovF7FLoMwH9wc5ohGgjh6JPUEIShH/WlQDoMF odMbbDUxhMK28vXD4QHORAXhhY2MxcIbgg7FQvQzKcFvR20yjWdJlNkI7L8CW+MIv/79 4qfju58NCyDXBatNXKNQv4CLhXxdFOSs4BQO12sDhihNIMnXvqBJJKWlf55FTbtIb0W4 Y5piQXCxHKU8yiqyT4mQ0PjHRWIPU4sa50FbKyNHcBmxdu44BPFzplftKkt+Li+Z1VLt 9gcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=p5NOTE254vm73Lsu62t4gF2fTVdlTH1aZ94SNqxQ8GA=; b=dIPsyU6u/KYhBTdFZIEAOyzMnE2caMxJ5HUEv5JC4Yzx9AKvYfLCAnUr+B9tXRE16m 1qucR1cMpbJgrQThcyyG5q0BSfDN6eWOt+QMBa3lo/Fl7hjdzIctzky8zssKSpssS4Oi HAXqqVfapulWhuzXB7JBoSgoJvPVlBIW5OHbilESF7xcpYFyM+NJYVS8QBjVhH1B5U8I JZUUlwSN1YbtPbsP9b9M1saF64PQ2OtJZJ4fRmhdAA0sqJFxSw5oiccYbq6qVk8oV0YX 6Q6E1H+YThAF4/6RQrSd5gmUy9Qpa1iHMgDxmfG8kdRQJ+uDfC3kqsry9TIn6bfxYW4h J/6A== X-Gm-Message-State: AOAM530OJOtj6W65EBlZsS+oFcBvUkMpTbWbSbZ5UeWhYbslXZOrsDK4 O72A1VoinMNvMJD6IPLuZwZbdiyL6X6jWA== X-Received: by 2002:a2e:760c:: with SMTP id r12mr5432858ljc.11.1608478164083; Sun, 20 Dec 2020 07:29:24 -0800 (PST) Received: from kari-VirtualBox (87-95-193-210.bb.dnainternet.fi. [87.95.193.210]) by smtp.gmail.com with ESMTPSA id f23sm1677699lfk.298.2020.12.20.07.29.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Dec 2020 07:29:23 -0800 (PST) Date: Sun, 20 Dec 2020 17:29:21 +0200 From: Kari Argillander To: Daniel West Cc: Larry.Finger@lwfinger.net, gregkh@linuxfoundation.org, insafonov@gmail.com, gustavoars@kernel.org, andrealmeidap1996@gmail.com, yepeilin.cs@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 8455/8455] staging: rtl8188eu: core: fixed a comment format issue. Message-ID: <20201220152921.dqlsmqfvygtpzj5b@kari-VirtualBox> References: <20201219224312.380126-1-daniel.west.dev@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201219224312.380126-1-daniel.west.dev@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Dec 19, 2020 at 02:43:12PM -0800, Daniel West wrote: > Fixed a checkpatch warning: > > WARNING: Block comments use * on subsequent lines > #4595: FILE: drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:4595: > +/**************************************************************************** > + > > The code is full of comments like this. Should the coding style > be inforced here, even when there is a logic to the way the code > was broken up? You should make one patch which atleast fix one file at ones. It would be even better if it fixes whole stuff (example one driver) right a way. Also note that you should not but this kind messages to your patch message. If you want to note this kind of thing you can use --- and after that it will not included in patch itself. You can read it online more. Also where does this [PATCH 8455/8455] even come from? Good thing is that you really didn't send so many patches or atleast I won't see them. And it seems that you are new so welcome a board :) -- Kari Argillander