Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Mime-Version: 1.0
Subject: RE: Re: [PATCH v16 1/3] scsi: ufs: Introduce HPB feature
Reply-To: daejun7.park@samsung.com
Sender: Daejun Park <daejun7.park@samsung.com>
From:   Daejun Park <daejun7.park@samsung.com>
To:     Greg KH <gregkh@linuxfoundation.org>,
        Daejun Park <daejun7.park@samsung.com>
CC:     "avri.altman@wdc.com" <avri.altman@wdc.com>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
        "stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
        "cang@codeaurora.org" <cang@codeaurora.org>,
        "huobean@gmail.com" <huobean@gmail.com>,
        "bvanassche@acm.org" <bvanassche@acm.org>,
        ALIM AKHTAR <alim.akhtar@samsung.com>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Sung-Jun Park <sungjun07.park@samsung.com>,
        yongmyung lee <ymhungry.lee@samsung.com>,
        Jinyoung CHOI <j-young.choi@samsung.com>,
        Adel Choi <adel.choi@samsung.com>,
        BoRam Shin <boram.shin@samsung.com>,
        SEUNGUK SHIN <seunguk.shin@samsung.com>
In-Reply-To: <X93XuJ4lsQbBgnU+@kroah.com>
Message-ID: <20201221023506epcms2p68be86df197976d1da2775f93709659c6@epcms2p6>
Date:   Mon, 21 Dec 2020 11:35:06 +0900
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 102P
DLP-Filter: Pass
References: <X93XuJ4lsQbBgnU+@kroah.com>
        <20201219091802epcms2p2c86f7ae2e81aa015702572a8ef180dae@epcms2p2>
        <20201219091847epcms2p7afeebd03c47eed0b65f89375a881233e@epcms2p7>
        <CGME20201219091802epcms2p2c86f7ae2e81aa015702572a8ef180dae@epcms2p6>
Precedence: bulk

Hi Greg,

> > +static void ufshpb_hpb_lu_prepared(struct ufs_hba *hba)
> > +{
> > +	struct ufshpb_lu *hpb;
> > +	struct scsi_device *sdev;
> > +	bool init_success;
> > +
> > +	init_success = !ufshpb_check_hpb_reset_query(hba);
> > +
> > +	shost_for_each_device(sdev, hba->host) {
> > +		hpb = sdev->hostdata;
> > +		if (!hpb)
> > +			continue;
> > +
> > +		if (init_success) {
> > +			dev_info(hba->dev, "set state to present\n");
> 
> Why be noisy?  Why does userspace need to see this all the time,
> shouldn't only errors be printing something?

I will remove needless dev_info printings in this patch.

Thanks,
Daejun