Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 21 Dec 2020 13:55:27 +1100
From:   Stephen Rothwell <sfr@canb.auug.org.au>
To:     Kuan-Ying Lee <Kuan-Ying.Lee@mediatek.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Andrey Konovalov <andreyknvl@google.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: build failure after merge of the akpm-current tree
Message-ID: <20201221135527.4cbdb11a@canb.auug.org.au>
In-Reply-To: <1608517898.9171.6.camel@mtksdccf07>
References: <20201221131017.128c89b1@canb.auug.org.au>
        <1608517898.9171.6.camel@mtksdccf07>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/nHyfFR7u4_cuD3Z=5bTr1+k";
 protocol="application/pgp-signature"; micalg=pgp-sha256
Precedence: bulk

--Sig_/nHyfFR7u4_cuD3Z=5bTr1+k
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

Hi Kuan-Ying,

On Mon, 21 Dec 2020 10:31:38 +0800 Kuan-Ying Lee <Kuan-Ying.Lee@mediatek.co=
m> wrote:
>
> On Mon, 2020-12-21 at 13:10 +1100, Stephen Rothwell wrote:
> >=20
> > After merging the akpm-current tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> >=20
> > mm/kasan/quarantine.c: In function 'quarantine_put':
> > mm/kasan/quarantine.c:207:15: error: 'info' undeclared (first use in th=
is function)
> >   207 |   qlink_free(&info->quarantine_link, cache);
> >       |               ^~~~
> >=20
> > Caused by commit
> >=20
> >   120d593a8650 ("kasan: fix memory leak of kasan quarantine")
> >=20
> > interacting with commit
> >=20
> >   cfbc92088e1d ("kasan: rename get_alloc/free_info")
> >=20
> > Can we please get this sorted out once and for all?
> >=20
> > I have applied the following patch for today:
> >=20
> > From: Stephen Rothwell <sfr@canb.auug.org.au>
> > Date: Mon, 21 Dec 2020 13:07:42 +1100
> > Subject: [PATCH] kasan: fix memory leak of kasan quarantine fix
> >=20
> > Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> > ---
> >  mm/kasan/quarantine.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >=20
> > diff --git a/mm/kasan/quarantine.c b/mm/kasan/quarantine.c
> > index 3f3b3d902c18..091a57f942b3 100644
> > --- a/mm/kasan/quarantine.c
> > +++ b/mm/kasan/quarantine.c
> > @@ -204,7 +204,7 @@ bool quarantine_put(struct kmem_cache *cache, void =
*object)
> > =20
> >  	q =3D this_cpu_ptr(&cpu_quarantine);
> >  	if (q->offline) {
> > -		qlink_free(&info->quarantine_link, cache);
> > +		qlink_free(&meta->quarantine_link, cache); // free once
> >  		local_irq_restore(flags);
> >  		return false;  // free twice
> >  	}
> > --=20
> > 2.29.2
> >  =20
>=20
> Please just drop this patch "kasan: fix memory leak of kasan quarantine"
> from linux-next. Otherwise, it would cause double free issue.

OK, so for today I have reverted my fix patch and 120d593a8650 ("kasan:
fix memory leak of kasan quarantine").

--=20
Cheers,
Stephen Rothwell

--Sig_/nHyfFR7u4_cuD3Z=5bTr1+k
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAl/gDp8ACgkQAVBC80lX
0GxN7ggAj/R2SMp5gZdUUQl2mbWK2pbglp2idMOQ+VNz6hqtPSHaAz2hWp4choVy
mqiJ4t/YjKoJ8BbvdEvlOFSP2jiuY/4eFlz3ZNVT+x7pEmBaEYKRweIWbpXpe/cO
uJwmiogIH1ZST6s+PtCbJ66iQImGouqhaC4YtZjlU4odQ9rF/IiiSYQ4d92g7MEr
gTW63bKFybLAx9lNWzgI/AVUFBuwrmFZ0eDacZvg5VzGD3qWyp62Al5RJ1bnKAB7
KW6bMoyj2d+b1NzEpgJ5LUgn6BjqwF2azGMpcv7ZMIGf6YZsGalMDIOOBGJWwIhP
s+EgdrnM3zS9s9XRTLvX3zDetvlOUg==
=DsWf
-----END PGP SIGNATURE-----

--Sig_/nHyfFR7u4_cuD3Z=5bTr1+k--