Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
User-Agent: Cyrus-JMAP/3.3.1-61-gb52c239-fm-20201210.001-gb52c2396
Mime-Version: 1.0
Message-Id: <e5de167a-707b-4668-85a0-3174309b9558@www.fastmail.com>
In-Reply-To: <HO0PLQ.1VZP0U76MARY1@crapouillou.net>
References: <20201221130048.7753-1-jiaxun.yang@flygoat.com>
 <HO0PLQ.1VZP0U76MARY1@crapouillou.net>
Date:   Mon, 21 Dec 2020 22:18:58 +0800
From:   "Jiaxun Yang" <jiaxun.yang@flygoat.com>
To:     "Paul Cercueil" <paul@crapouillou.net>
Cc:     "linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>,
        "Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MIPS: zboot: head.S clean up
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk


On Mon, Dec 21, 2020, at 10:09 PM, Paul Cercueil wrote:
> Hi Jiaxun,
>=20
> Le lun. 21 d=C3=A9c. 2020 =C3=A0 21:00, Jiaxun Yang <jiaxun.yang@flygo=
at.com> a=20
> =C3=A9crit :
> > .cprestore is removed as we don't except Position Independent
> > zboot ELF.
> >=20
> > .noreorder is also removed and rest instructions is massaged
> > to improve readability.
> >=20
> > t9 register is used to indirect jump as MIPS ABI requirement.
> >=20
> > Reported-by: Paul Cercueil <paul@crapouillou.net>
> > Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
> > ---
> >  arch/mips/boot/compressed/head.S | 17 +++++++----------
> >  1 file changed, 7 insertions(+), 10 deletions(-)
> >=20
> > diff --git a/arch/mips/boot/compressed/head.S=20
> > b/arch/mips/boot/compressed/head.S
> > index 409cb483a9ff..977218c90bc8 100644
> > --- a/arch/mips/boot/compressed/head.S
> > +++ b/arch/mips/boot/compressed/head.S
> > @@ -15,8 +15,6 @@
> >  #include <asm/asm.h>
> >  #include <asm/regdef.h>
> >=20
> > -	.set noreorder
> > -	.cprestore
> >  	LEAF(start)
> >  start:
>=20
> You can also remove the 'start' label, since it's declared inside the=20=

> LEAF() macro as well. GNU's assembler won't mind, but LLVM will choke=20=

> on that.

Thanks, will do in v2!

I was trying to catch you on IRC but failed every time when it comes to =
my mind :-(

>=20
> Cheers,
> -Paul
>=20

- Jiaxun