Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 2/2] checkpatch: kconfig: add missing types to regex
To:     Joe Perches <joe@perches.com>, linux-kernel@vger.kernel.org
References: <a9797282-84c3-2c8f-73a0-d751a8201541@fau.de>
 <1f3b50a6f343dd252c043b2e5b7d47bca8514ee7.camel@perches.com>
Cc:     apw@canonical.com, johannes.czekay@fau.de,
        linux-kernel@i4.cs.fau.de
From:   Nicolai Fischer <nicolai.fischer@fau.de>
Message-ID: <5d7cef4f-071d-0504-74df-bd944a11dd70@fau.de>
Date:   Mon, 21 Dec 2020 16:08:11 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.0
MIME-Version: 1.0
In-Reply-To: <1f3b50a6f343dd252c043b2e5b7d47bca8514ee7.camel@perches.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk


On Sun, 2020-12-20 at 20:16 +0100, Joe Perches wrote:
> On Mon, 2020-12-14 at 11:24 +0100, Nicolai Fischer wrote:
>> Kconfig parsing does not recognise all type attributes.
>> This adds the missing 'int', 'sting' and 'hex' types.
> []
>> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> []
>> @@ -3321,7 +3321,7 @@ sub process {
>>  				next if ($f =~ /^-/);
>>  				last if (!$file && $f =~ /^\@\@/);
>>  
>>
>> -				if ($lines[$ln - 1] =~ /^\+\s*(?:bool|tristate|prompt)\s*["']/) {
>> +				if ($lines[$ln - 1] =~ /^\+\s*(?:bool|tristate|int|hex|string|prompt)\s*["']/) {
>>  					$is_start = 1;
>>  				} elsif ($lines[$ln - 1] =~ /^\+\s*help$/) {
>>  					$length = -1;
> 
> Another thing that could be done is to enforce the "extra 2 spaces"
> indent by capturing the whitespace before the help keyword:
> 
> 				} elsif ($lines[$ln - 1] =~ /^\+\s*help$/) {
> 
> could be
> 
> 				} elsif ($lines[$ln - 1] =~ /^\+(\s*)help\s*$/) {
> 
> with $1 used to validate the extra indent.
> 
> 


In case the indent does not match, should we display a new warning as in our previous patch?

On Tue, 2020-12-08 at 14:35 +0100, Nicolai Fischer wrote> +				WARN("CONFIG_DESCRIPTION",
> +					"help text is not indented 2 spaces more than the help keyword\n" . $herecurr);