Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1608277668-3740-1-git-send-email-huangzhaoyang@gmail.com>
In-Reply-To: <1608277668-3740-1-git-send-email-huangzhaoyang@gmail.com>
From:   Todd Kjos <tkjos@google.com>
Date:   Mon, 21 Dec 2020 10:57:57 -0800
Message-ID: <CAHRSSEwGHqQHRzyBUAyqVZk4azr8aeJ_Hgw=_XzaSkfTiVEBcg@mail.gmail.com>
Subject: Re: [PATCH] driver: staging: count ashmem_range into SLAB_RECLAIMBLE
To:     Huangzhaoyang <huangzhaoyang@gmail.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        =?UTF-8?B?QXJ2ZSBIasO4bm5ldsOlZw==?= <arve@android.com>,
        Todd Kjos <tkjos@android.com>,
        Martijn Coenen <maco@android.com>,
        Joel Fernandes <joel@joelfernandes.org>,
        Christian Brauner <christian@brauner.io>,
        "open list:ANDROID DRIVERS" <devel@driverdev.osuosl.org>,
        Zhaoyang Huang <zhaoyang.huang@unisoc.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Suren Baghdasaryan <surenb@google.com>,
        Hridya Valsaraju <hridya@google.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

+Hridya Valsaraju +Suren Baghdasaryan


On Thu, Dec 17, 2020 at 11:48 PM Huangzhaoyang <huangzhaoyang@gmail.com> wrote:
>
> From: Zhaoyang Huang <zhaoyang.huang@unisoc.com>
>
> Add SLAB_RECLAIM_ACCOUNT to ashmem_range cache since it has registered
> shrinker, which make memAvailable more presiced.
>
> Signed-off-by: Zhaoyang Huang <zhaoyang.huang@unisoc.com>

Acked-by: Todd Kjos <tkjos@google.com>

> ---
>  drivers/staging/android/ashmem.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c
> index 74d497d..b79301f 100644
> --- a/drivers/staging/android/ashmem.c
> +++ b/drivers/staging/android/ashmem.c
> @@ -893,7 +893,7 @@ static int __init ashmem_init(void)
>
>         ashmem_range_cachep = kmem_cache_create("ashmem_range_cache",
>                                                 sizeof(struct ashmem_range),
> -                                               0, 0, NULL);
> +                                               0, SLAB_RECLAIM_ACCOUNT, NULL);
>         if (!ashmem_range_cachep) {
>                 pr_err("failed to create slab cache\n");
>                 goto out_free1;
> --
> 1.9.1
>