Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp4614542pxu; Mon, 21 Dec 2020 18:02:50 -0800 (PST) X-Google-Smtp-Source: ABdhPJzBQgCk5TIjAPrzYw8U7OdOf9st6YCXtC3ORAnpLkDnMx/Ys4loi+/aE+Dbv8if+zW9E0aE X-Received: by 2002:a17:906:17c3:: with SMTP id u3mr17617682eje.304.1608602570601; Mon, 21 Dec 2020 18:02:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1608602570; cv=none; d=google.com; s=arc-20160816; b=JoIGOGdka1EuFqvk7pPeoGKXSR7sgjaZu3dj4v7u+0D68garfgRLrXr20pcFMTBa7L y/q+TS0Q2P9feZxSNhZ+KxX9XxzIOr0SL0vXCkV3Q7nlnDhEbzb3bKrXWXXW2prYS5Y+ nFaoSw/gxKatQpgllbjqpiqojRttcAU+vi3JDyBmldBAnqk+VCOMOL2rR+Mc5ZpE8h6S sDjU4nlTZk0lCABFpj3rswC5Rgs1Ay+88DbttpXr7vcKovJb6hzObaipJaNH1+6SyBPO iOmB9KRbxMjJOa+FEfoNK/cvklBcT+1G1SThSTVG5PPhFxdg4zZZfWvyJo3ksuoxrhBf kIIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=uzA+Ho0hocE3T4iZfuBR4Toi2hQH0RRs8tjI9CwkGqs=; b=XCIzVzs+ORU7bpR4HCG4LYzVDSB7OhybmsN7wZUEpx+lA21/xG8wH2dUlgDQvK3BwE GvBiybaq1+T/JdI9ySLMzjRpkuTo1LAeXeX/NE7icfeRLcY7Y1s3rbFOUls9aZleLYgV cUOPTFjahke0tS7hwMX78B7yxug5PYsY21bYDK8lQU8bqhnHVTqxSL7H0ZMbpcYjT00g J+HJ9HXwivgeh9ZL3m53lwED5YmIUzRmYXjP+AyMavZWljXB57co9gRalfM8tlyflyCo Qopa5p0+x0fqwNm4hIscD9EtZRriMQGmbYitoR/dfZYoWPTZIYW7llAMlyI8fBxi71jF bdrA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="Ax/o0iay"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id el22si10308057ejc.362.2020.12.21.18.02.28; Mon, 21 Dec 2020 18:02:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="Ax/o0iay"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726472AbgLVCA0 (ORCPT + 99 others); Mon, 21 Dec 2020 21:00:26 -0500 Received: from mail.kernel.org ([198.145.29.99]:59030 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725850AbgLVCAZ (ORCPT ); Mon, 21 Dec 2020 21:00:25 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9195622B3B; Tue, 22 Dec 2020 01:59:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1608602385; bh=MpYfLO66Zem586idWaT6mjA3K0YrVVbMETgKtaR+fnU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Ax/o0iayyOnKobbTkdtRrbsmWbuOfUq1MmonmYQEgnA9GCKsweJ31OM02d0pH6GFH QpuvWlEZE9aesiB9si0y0NHdMVLZQgeUrhzJddIOcvmGSvLPG8JdS8+sQgurJ34u+/ fPjDpxuemG6+NDVsetQFbvde1/Ueay0LQiG8P4l1aX4RXC29q9muVedpAifc4Z3sRu GgfJJWvLksfDNgoDaHxfLnrbHT1Z4bpdu4YWGePqq/4KTiVPZnHY/Pf7Z5NK8KUTXf +1OGX5qeJkj2U992Okvyycvxyuj17PxLrrXLxU5PlyZsN+wOOuB+y09jw9BIHbCfuY pWIMrvtIk/tpA== Date: Mon, 21 Dec 2020 17:59:43 -0800 From: Jakub Kicinski To: Oleksij Rempel Cc: Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Russell King , Pengutronix Kernel Team , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org Subject: Re: [PATCH v6 net-next 2/2] net: dsa: qca: ar9331: export stats64 Message-ID: <20201221175943.0990ee18@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20201219195833.29197-3-o.rempel@pengutronix.de> References: <20201219195833.29197-1-o.rempel@pengutronix.de> <20201219195833.29197-3-o.rempel@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 19 Dec 2020 20:58:33 +0100 Oleksij Rempel wrote: > + stats->rx_nohandler += raw.filtered; > + stats->rx_errors += raw.rxfcserr + raw.rxalignerr + raw.rxrunt + > + raw.rxfragment + raw.rxoverflow + raw.filtered + raw.rxtoolong; What happened to my suggestion to report filtered in dropped? If you repost before -rc1 please post as RFC as net-next is currently closed. -- # Form letter - net-next is closed We have already sent the networking pull request for 5.11 and therefore net-next is closed for new drivers, features, code refactoring and optimizations. We are currently accepting bug fixes only. Please repost when net-next reopens after 5.11-rc1 is cut. Look out for the announcement on the mailing list or check: http://vger.kernel.org/~davem/net-next.html RFC patches sent for review only are obviously welcome at any time.