Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1608606010-7412-1-git-send-email-yangtiezhu@loongson.cn>
In-Reply-To: <1608606010-7412-1-git-send-email-yangtiezhu@loongson.cn>
From:   Masahiro Yamada <masahiroy@kernel.org>
Date:   Tue, 22 Dec 2020 12:46:06 +0900
Message-ID: <CAK7LNATcDYrBj-k72=ZSrFxwoBtQOwO=6c8_DyW2rY-C37g3Og@mail.gmail.com>
Subject: Re: [PATCH] Makefile: Remove Module.symvers when make clean
To:     Tiezhu Yang <yangtiezhu@loongson.cn>
Cc:     Michal Marek <michal.lkml@markovi.net>,
        Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Xuefeng Li <lixuefeng@loongson.cn>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Dec 22, 2020 at 12:00 PM Tiezhu Yang <yangtiezhu@loongson.cn> wrote:
>
> Module.symvers still exists when make clean, remove it.
>
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>


NACK.

Module.symver is removed by "make mrproper"
since it is needed for building external modules.


> ---
>  Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index e30cf02..8235bb7 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1468,7 +1468,7 @@ endif # CONFIG_MODULES
>
>  # Directories & files removed with 'make clean'
>  CLEAN_FILES += include/ksym vmlinux.symvers \
> -              modules.builtin modules.builtin.modinfo modules.nsdeps \
> +              modules.builtin modules.builtin.modinfo modules.nsdeps Module.symvers\
>                compile_commands.json
>
>  # Directories & files removed with 'make mrproper'
> --
> 2.1.0
>


-- 
Best Regards
Masahiro Yamada