Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201220123957.1694-1-wangzhiqiang.bj@bytedance.com>
In-Reply-To: <20201220123957.1694-1-wangzhiqiang.bj@bytedance.com>
From:   Joel Stanley <joel@jms.id.au>
Date:   Tue, 22 Dec 2020 06:13:14 +0000
Message-ID: <CACPK8XexOmUOdGmHCYVXVgA0z5m99XCAbixcgODSoUSRNCY+zA@mail.gmail.com>
Subject: Re: [PATCH] net/ncsi: Use real net-device for response handler
To:     John Wang <wangzhiqiang.bj@bytedance.com>
Cc:     xuxiaohan@bytedance.com,
        =?UTF-8?B?6YOB6Zu3?= <yulei.sh@bytedance.com>,
        Samuel Mendoza-Jonas <sam@mendozajonas.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Gavin Shan <gwshan@linux.vnet.ibm.com>,
        "open list:NETWORKING [GENERAL]" <netdev@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sun, 20 Dec 2020 at 12:40, John Wang <wangzhiqiang.bj@bytedance.com> wrote:
>
> When aggregating ncsi interfaces and dedicated interfaces to bond
> interfaces, the ncsi response handler will use the wrong net device to
> find ncsi_dev, so that the ncsi interface will not work properly.
> Here, we use the net device registered to packet_type to fix it.
>
> Fixes: 138635cc27c9 ("net/ncsi: NCSI response packet handler")
> Signed-off-by: John Wang <wangzhiqiang.bj@bytedance.com>

Can you show me how to reproduce this?

I don't know the ncsi or net code well enough to know if this is the
correct fix. If you are confident it is correct then I have no
objections.

Cheers,

Joel

> ---
>  net/ncsi/ncsi-rsp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/ncsi/ncsi-rsp.c b/net/ncsi/ncsi-rsp.c
> index a94bb59793f0..60ae32682904 100644
> --- a/net/ncsi/ncsi-rsp.c
> +++ b/net/ncsi/ncsi-rsp.c
> @@ -1120,7 +1120,7 @@ int ncsi_rcv_rsp(struct sk_buff *skb, struct net_device *dev,
>         int payload, i, ret;
>
>         /* Find the NCSI device */
> -       nd = ncsi_find_dev(dev);
> +       nd = ncsi_find_dev(pt->dev);
>         ndp = nd ? TO_NCSI_DEV_PRIV(nd) : NULL;
>         if (!ndp)
>                 return -ENODEV;
> --
> 2.25.1
>