Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp4754585pxu; Mon, 21 Dec 2020 23:10:50 -0800 (PST) X-Google-Smtp-Source: ABdhPJzCcm1CvUQL0A2qUqj2EIcjTxbblAcqmuKuyjkxviAahI8BUC1jgP1bSHtdPxIZWvxrrKyr X-Received: by 2002:a05:6402:1ad1:: with SMTP id ba17mr18763449edb.51.1608621049871; Mon, 21 Dec 2020 23:10:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1608621049; cv=none; d=google.com; s=arc-20160816; b=nyaZNlFmCMuq+Xe2M7XglSi3H4mhCueyJmNsBrqk+CRA/lVQdH7hIloQ/BKD8r7OaP bBSkbklKMrUbOTXdrIPxLzllnJ4O1OvyYhp88+OLxONoNQ8itYZhDOResTOFLk1dqqLN enjb/fWIKK632MxjJhrKTmlrcaIhDwOSDd+5N3uZ/Of2OcLMz3JFjR4mQPyTJhIw1597 u5pZ6q68+9t+Ok3uwUQnT+75IWcuzoq/+5Ch4MPB/1utsPBX4bBqf2frtsKAZdM3lYkm /wuXH6ssf4x7WRPOJwmi3LOOm1UIbKV0D+pHwE3H+KycsBwRPzLnthHpot29ICZcDaNh pcVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=VJqLp0B6wsoQw818imRrANiYGP3C4WMw05P8ap2+hgw=; b=OO9R4zysdeMirin/pN5zLa6MA0/2GBYmS5YeY+iAJy0rPToM0m9QgPgkzPUN8dbiYG 2eSUe+jZhH0ClEt9SWJpGya84pOhpt7EetP+Y8kdN2v7MvhKbaDH3WMuhCNPMCV5/nEV +L9ny5+ki8Grz1PXpf+SgprErQjohS/2RJdVtcxpvkXawa406zgYh2sCzoIdeCXrGbZi KMo+rAZ40DzN5Q7czKueCJMyhsAolu+B4Y4qOzutpn/Z2ILta0vqLbeF/b2wRHE13ePn KLG60NNcrVugPEDSiKwcMM5H+eKEwhFl8tNKf62INQv8C4jlTm28TQbCc21KBLeQ57ZG Vnng== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b="iyRKpS/F"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gj15si10497252ejb.597.2020.12.21.23.10.27; Mon, 21 Dec 2020 23:10:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b="iyRKpS/F"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726289AbgLVHJ6 (ORCPT + 99 others); Tue, 22 Dec 2020 02:09:58 -0500 Received: from perceval.ideasonboard.com ([213.167.242.64]:41900 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726025AbgLVHJ6 (ORCPT ); Tue, 22 Dec 2020 02:09:58 -0500 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id BCA0D9E6; Tue, 22 Dec 2020 08:09:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1608620954; bh=VH+sNIDHdF2vto78fqqJB6mWZwyWSfrL6TYP0PHE3xc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iyRKpS/FHTAX53XZRUthWRpJGyP7509SFeIJ40/4n10Klx7n93XpRBLuJ1tAtgaXv A89B2GHJc3oCkDQeCNSDyCwJngwH0kHQ8XbgmWaOW1Mp41XKeHPql35r5RYv/LTJqK RX55kyGGc6rP72KB8RXFp6AUDoglDPPzM+xU0m7o= Date: Tue, 22 Dec 2020 09:09:07 +0200 From: Laurent Pinchart To: Liu Ying Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, airlied@linux.ie, daniel@ffwll.ch, robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, mchehab@kernel.org, a.hajda@samsung.com, narmstrong@baylibre.com, jonas@kwiboo.se, jernej.skrabec@siol.net, kishon@ti.com, vkoul@kernel.org Subject: Re: [PATCH 06/14] dt-bindings: display: bridge: Add i.MX8qm/qxp display pixel link binding Message-ID: References: <1608199173-28760-1-git-send-email-victor.liu@nxp.com> <1608199173-28760-7-git-send-email-victor.liu@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1608199173-28760-7-git-send-email-victor.liu@nxp.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Liu, Thank you for the patch. On Thu, Dec 17, 2020 at 05:59:25PM +0800, Liu Ying wrote: > This patch adds bindings for i.MX8qm/qxp display pixel link. > > Signed-off-by: Liu Ying > --- > .../display/bridge/fsl,imx8qxp-pixel-link.yaml | 128 +++++++++++++++++++++ > 1 file changed, 128 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-pixel-link.yaml > > diff --git a/Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-pixel-link.yaml b/Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-pixel-link.yaml > new file mode 100644 > index 00000000..fd24a0e > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-pixel-link.yaml > @@ -0,0 +1,128 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/bridge/fsl,imx8qxp-pixel-link.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Freescale i.MX8qm/qxp Display Pixel Link > + > +maintainers: > + - Liu Ying > + > +description: | > + The Freescale i.MX8qm/qxp Display Pixel Link(DPL) forms a standard > + asynchronous linkage between pixel sources(display controller or > + camera module) and pixel consumers(imaging or displays). > + It consists of two distinct functions, a pixel transfer function and a > + control interface. Multiple pixel channels can exist per one control channel. > + This binding documentation is only for pixel links whose pixel sources are > + display controllers. > + > +properties: > + compatible: > + enum: > + - fsl,imx8qm-dc-pixel-link > + - fsl,imx8qxp-dc-pixel-link > + > + ports: > + type: object > + description: | > + A node containing pixel link input & output port nodes with endpoint > + definitions as documented in > + Documentation/devicetree/bindings/media/video-interfaces.txt > + Documentation/devicetree/bindings/graph.txt With Rob's patch that convert both of these to YAML, I think you can drop the references to these documents, and use $ref: /schemas/graph.yaml#/properties/ports in the ports node, and $ref: /schemas/graph.yaml#/$defs/port-base unevaluatedProperties: false in the port nodes, dropping the type property. You will also be able to drop additionalProperties: false for the ports node. > + > + properties: > + '#address-cells': > + const: 1 > + > + '#size-cells': > + const: 0 > + > + port@0: > + type: object > + description: The pixel link input port node from upstream video source. > + > + properties: > + reg: > + const: 0 > + > + required: > + - reg > + > + patternProperties: > + "^port@[1-4]$": > + type: object > + description: The pixel link output port node to downstream bridge. > + > + properties: > + reg: > + enum: [ 1, 2, 3, 4 ] > + > + required: > + - reg > + > + required: > + - "#address-cells" > + - "#size-cells" > + - port@0 > + > + anyOf: > + - required: > + - port@1 > + - required: > + - port@2 > + - required: > + - port@3 > + - required: > + - port@4 Do all DPL instances have four output ports ? If so I would make all of them mandatory, as they describe the hardware. They can be left without any endpoing if they're not connected to anything. > + > + additionalProperties: false > + > +required: > + - compatible > + - ports > + > +additionalProperties: false > + > +examples: > + - | > + dc0-pixel-link0 { > + compatible = "fsl,imx8qxp-dc-pixel-link"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + /* from dc0 pixel combiner channel0 */ > + port@0 { > + reg = <0>; > + > + dc0_pixel_link0_dc0_pixel_combiner_ch0: endpoint { > + remote-endpoint = <&dc0_pixel_combiner_ch0_dc0_pixel_link0>; > + }; > + }; > + > + /* to PXL2DPIs in MIPI/LVDS combo subsystems */ > + port@1 { > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <1>; > + > + dc0_pixel_link0_mipi_lvds_0_pxl2dpi: endpoint@0 { > + reg = <0>; > + remote-endpoint = <&mipi_lvds_0_pxl2dpi_dc0_pixel_link0>; > + }; > + > + dc0_pixel_link0_mipi_lvds_1_pxl2dpi: endpoint@1 { > + reg = <1>; > + remote-endpoint = <&mipi_lvds_1_pxl2dpi_dc0_pixel_link0>; > + }; > + }; > + > + /* to imaging subsystem */ > + port@4 { > + reg = <4>; > + }; > + }; > + }; -- Regards, Laurent Pinchart