Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965072AbWIEN43 (ORCPT ); Tue, 5 Sep 2006 09:56:29 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965073AbWIEN43 (ORCPT ); Tue, 5 Sep 2006 09:56:29 -0400 Received: from mx1.redhat.com ([66.187.233.31]:28032 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S965072AbWIEN42 (ORCPT ); Tue, 5 Sep 2006 09:56:28 -0400 Subject: Re: [PATCH 07/16] GFS2: Directory handling From: Steven Whitehouse To: Ingo Molnar Cc: Jan Engelhardt , linux-kernel@vger.kernel.org, Russell Cattelan , David Teigland , hch@infradead.org In-Reply-To: <20060905084334.GA16788@elte.hu> References: <1157031298.3384.797.camel@quoit.chygwyn.com> <1157445854.3384.965.camel@quoit.chygwyn.com> <20060905084334.GA16788@elte.hu> Content-Type: text/plain Organization: Red Hat (UK) Ltd Date: Tue, 05 Sep 2006 15:02:03 +0100 Message-Id: <1157464923.3384.1014.camel@quoit.chygwyn.com> Mime-Version: 1.0 X-Mailer: Evolution 2.2.2 (2.2.2-5) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1144 Lines: 35 On Tue, 2006-09-05 at 10:43 +0200, Ingo Molnar wrote: > * Steven Whitehouse wrote: [some lines snipped] > > > >+ if ((char *)cur + cur_rec_len >= bh_end) { > > > >+ if ((char *)cur + cur_rec_len > bh_end) { > > > >+ gfs2_consist_inode(dip); > > > >+ return -EIO; > > > >+ } > > > >+ return -ENOENT; > > > >+ } > > > > > > if((char *)cur + cur_rec_len > bh_end) { > > > gfs2_consist_inode(dip); > > > return -EIO; > > > } else if((char *)cur + cur_rec_len == bh_end) > > > return -ENOENT; > > > > > ok > > this one is not OK! Firstly, Jan, and i mentioned this before, please > stop using 'if(', it is highly inconsistent and against basic taste. We > only use this construct for function calls (and macros), not for C > statements. I did use use if "if (" form when I made this change rather than a direct copy & paste from this. So it is ok I think, Steve. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/