Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp4895515pxu; Tue, 22 Dec 2020 03:35:58 -0800 (PST) X-Google-Smtp-Source: ABdhPJzb4C1pnyUe8YQHxR/deXvmMJJv9ud2bGyPc5BwVHzgBIfH5zs7vfbtcsGJ2tI/LUzsNeIV X-Received: by 2002:a17:906:eb8d:: with SMTP id mh13mr18980329ejb.299.1608636958444; Tue, 22 Dec 2020 03:35:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1608636958; cv=none; d=google.com; s=arc-20160816; b=H/VDnxXtSoPCBxlTvaeUsBIghcXdswK47zVOGZKpn8U2BNkoHwJC/PTJqzI3RtMyEl ONYtVcj9VqSGfwd8yAy2bsgUsIiY5i+TCwe6FtM6sAwHlT2GMsboA375y4BV0uFkDEIr YlvH+KQfazqxDM45CTCQvI2xl1tHWOStKpP/MVbldICRbF62SjfaXxD4Jc+tVYdGxXih TyTle6Jkx7eJIliYHdahpX3+7Bm5BGWIJsC5DW0jKERrno1NueXquh6nCLcry/cYDW22 XSfUM18gU+enzOkL+aSle+Ib7VNiLfYUDhhlWwGuMUMVPXGiLap/5pJgKPmFTgAe5DgA T2kQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-language:content-transfer-encoding :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=/LLhtHFgPBOK2OFOhahQrs85+vL9vDQkg8GASr1h8xM=; b=OpPlNTOV5m71C86a+byDZi3rpbhmZJ7NRqZ5rMsnO2gCBRWwEUMlB3w3l25IjOPeXg XqwJdT2LTFVDC/JTmUk8PLCUQW8sJfY+Oi5jcwu59ER4Tb+lEYRWZcisqEHEBEC7c4a5 8z5jLtdjXTQpKuOVResjrCf7cZuRrfUV59FZDwdkRvnI4CppFZxZClu9Z8yxX06UQMCE hJtTlqafw987+w3FT+7/9sNcLo88x4CIIbyWZ+sbdbuxZgddBF1Bdqd2+Gzrs1qZrGyw jpohGjuj+qYuHJ/XDuF+zSB7G/czvmfxTQKDABZw1UtSBbaaTLFPa9neQNLbQVeh4Xjw QCuQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id kt11si10517697ejb.445.2020.12.22.03.35.36; Tue, 22 Dec 2020 03:35:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726881AbgLVLeo (ORCPT + 99 others); Tue, 22 Dec 2020 06:34:44 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:10057 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726463AbgLVLeo (ORCPT ); Tue, 22 Dec 2020 06:34:44 -0500 Received: from DGGEMS409-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4D0Z2m0WCnzM7yQ; Tue, 22 Dec 2020 19:33:04 +0800 (CST) Received: from [127.0.0.1] (10.40.192.131) by DGGEMS409-HUB.china.huawei.com (10.3.19.209) with Microsoft SMTP Server id 14.3.498.0; Tue, 22 Dec 2020 19:33:53 +0800 Subject: Re: [PATCH v1] gpio: hisi: delete some unused variables in hisi_gpio_probe() To: Andy Shevchenko CC: Linus Walleij , Andy Shevchenko , "open list:GPIO SUBSYSTEM" , Linux Kernel Mailing List References: <1608539124-4914-1-git-send-email-luojiaxing@huawei.com> From: luojiaxing Message-ID: <5be97c5e-39fc-bf58-aee5-39438948b059@huawei.com> Date: Tue, 22 Dec 2020 19:33:53 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [10.40.192.131] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/12/21 18:35, Andy Shevchenko wrote: > On Mon, Dec 21, 2020 at 10:25 AM Luo Jiaxing wrote: >> kernel test rebot report that dat, set and clr in hisi_gpio_probe() is >> unused variables. So delete it. > Fixes: tag? Fixes: 356b01a986a5 ("gpio: gpio-hisi: Add HiSilicon GPIO support") Should I send v2 to add this tag? or we can ask linus to help to add it when apply this? Thanks Jiaxing > >> Reported-by: kernel test robot >> Signed-off-by: Luo Jiaxing