Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp4896445pxu; Tue, 22 Dec 2020 03:37:26 -0800 (PST) X-Google-Smtp-Source: ABdhPJzZBkU1DbxRFVsQDzaG4mBxZL+rglgj3ibTpioewBTU23Ir6aJFtnWT2c11V0uPAQgpYYf/ X-Received: by 2002:a17:907:9627:: with SMTP id gb39mr19675068ejc.267.1608637046312; Tue, 22 Dec 2020 03:37:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1608637046; cv=none; d=google.com; s=arc-20160816; b=pMx5lymBczVtmWolmjRnBVsrNZyZdUtBa6nzpzFTVtYEmiqMty3vM+kcGMqCfoG1NF W59z0iz0HLhGa2jk45A3l8pPRkdDDzOow3o60mprH50Hb3iRufmUZ30uPx3c6vzjgmLN hy4NqPppGPxiza9K+uxZfIjUEbYx97t4mXWWWPbi+DiixndiVx97rat0vb6kdG90tm9q ZNzljdZ7IOT7vpfARGE3GKX+f/5+L0CiE4GHC4uKr9J0eQ0AdX9N3ep2xBGmJ+aDq7g5 kMNgcbG4p9YSlDQHyCXNMHjZIrPgZ4zOGUJXjxA0alK6KcsZomPzouoyhOhPvbOqJd/X vWBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:message-id:references:in-reply-to :subject:cc:to:from:date:content-transfer-encoding:mime-version :sender:dkim-signature; bh=VzpQ5rwXRSrUDR5+QdfdTTAyPqtNIHURgGYaJE8HPCk=; b=xSZuuFV6lBzfcc44zJVgYSBDm3OQhKL10oKH/XIKRdxLNmgwD/EAxWK2C/fdM4w3fa DTVBSbK10Ssa1v38uKJ8fL/3lZfD//EFf1MuhGf3NyTIg7uza4vgMS3haQhDLhadzbmx C5keUWN1KyVgrXBgjeAoYgqoisIPi3fE9dwzgJgGxrr+FawyOX3qgKk2skGpoXJJ/7u6 FC5tPLLVbZBFLuykTuCPSr3a/ZpA1dxkGAKqxdZwfeFSdEyS5WxJSaHPMc4ywN1+BV3t zNgG1Sj//u9clgrQ7m6y3bYCAKMFtLoprML6xLQao9mc2/TGwP47YpipdYmEJoWfHxIk QXFg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=W1IBtauK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d3si13313228edj.258.2020.12.22.03.37.03; Tue, 22 Dec 2020 03:37:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=W1IBtauK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727006AbgLVLfQ (ORCPT + 99 others); Tue, 22 Dec 2020 06:35:16 -0500 Received: from so254-31.mailgun.net ([198.61.254.31]:41771 "EHLO so254-31.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726673AbgLVLfP (ORCPT ); Tue, 22 Dec 2020 06:35:15 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1608636896; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=VzpQ5rwXRSrUDR5+QdfdTTAyPqtNIHURgGYaJE8HPCk=; b=W1IBtauKty4gM1xZLHngX71332XqEM2Twhedz5rE1PkLCDK4b9+saiL1ZFtE0ndK5BzU+O3B ak7znHEJfPvxKkNhgSpqT9gWU58ig9PIugt8qHrJmRLoVyN5vFWyl+YCdTe95xbp6gSj+eRJ rgCIfE4fXb7WlJrD6Q8uHSxHqfc= X-Mailgun-Sending-Ip: 198.61.254.31 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n03.prod.us-west-2.postgun.com with SMTP id 5fe1d9d4cfd94dd328496568 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 22 Dec 2020 11:34:44 GMT Sender: cang=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id D7D2BC433C6; Tue, 22 Dec 2020 11:34:44 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=ALL_TRUSTED,BAYES_00 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: cang) by smtp.codeaurora.org (Postfix) with ESMTPSA id 4B22DC433ED; Tue, 22 Dec 2020 11:34:43 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 22 Dec 2020 19:34:43 +0800 From: Can Guo To: Stanley Chu Cc: linux-scsi@vger.kernel.org, martin.petersen@oracle.com, avri.altman@wdc.com, alim.akhtar@samsung.com, jejb@linux.ibm.com, beanhuo@micron.com, asutoshd@codeaurora.org, matthias.bgg@gmail.com, bvanassche@acm.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kuohong.wang@mediatek.com, peter.wang@mediatek.com, chun-hung.wu@mediatek.com, andy.teng@mediatek.com, chaotian.jing@mediatek.com, cc.chou@mediatek.com, jiajie.hao@mediatek.com, alice.chao@mediatek.com Subject: Re: [PATCH v1] scsi: ufs-mediatek: Enable UFSHCI_QUIRK_SKIP_MANUAL_WB_FLUSH_CTRL In-Reply-To: <20201222072928.32328-1-stanley.chu@mediatek.com> References: <20201222072928.32328-1-stanley.chu@mediatek.com> Message-ID: X-Sender: cang@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-12-22 15:29, Stanley Chu wrote: > Flush during hibern8 is sufficient on MediaTek platforms, thus > enable UFSHCI_QUIRK_SKIP_MANUAL_WB_FLUSH_CTRL to skip enabling > fWriteBoosterBufferFlush during WriteBooster initialization. > > Signed-off-by: Stanley Chu > --- > drivers/scsi/ufs/ufs-mediatek.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/scsi/ufs/ufs-mediatek.c > b/drivers/scsi/ufs/ufs-mediatek.c > index 80618af7c872..c55202b92a43 100644 > --- a/drivers/scsi/ufs/ufs-mediatek.c > +++ b/drivers/scsi/ufs/ufs-mediatek.c > @@ -661,6 +661,7 @@ static int ufs_mtk_init(struct ufs_hba *hba) > > /* Enable WriteBooster */ > hba->caps |= UFSHCD_CAP_WB_EN; > + hba->quirks |= UFSHCI_QUIRK_SKIP_MANUAL_WB_FLUSH_CTRL; > hba->vps->wb_flush_threshold = UFS_WB_BUF_REMAIN_PERCENT(80); > > if (host->caps & UFS_MTK_CAP_DISABLE_AH8) I guess we need it too... Change LGTM. Regards, Can Guo.