Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1608638156-7879-1-git-send-email-tiantao6@hisilicon.com>
In-Reply-To: <1608638156-7879-1-git-send-email-tiantao6@hisilicon.com>
From:   Daniel Vetter <daniel@ffwll.ch>
Date:   Tue, 22 Dec 2020 13:34:22 +0100
Message-ID: <CAKMK7uGpvnmAH0GGfM0G_UgnqvwUWsyQuTwVvJ870fpqxgeSxQ@mail.gmail.com>
Subject: Re: [PATCH] drm/hisilicon: Remove drm_dev_put in hibmc
To:     Tian Tao <tiantao6@hisilicon.com>
Cc:     Dave Airlie <airlied@linux.ie>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        Gerd Hoffmann <kraxel@redhat.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        dri-devel <dri-devel@lists.freedesktop.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Dec 22, 2020 at 12:56 PM Tian Tao <tiantao6@hisilicon.com> wrote:
>
> Hibmc use the devm_drm_dev_alloc function in hibmc_pci_probe, if
> hibmc_pci_probe returns non-zero, devm_drm_dev_alloc will call
> devm_drm_dev_init, which will call devm_drm_dev_init_release to
> release drm_dev_put. There is no need for hibmc to call
> drm_dev_put separately.
>
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>

lgtm, Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>

Cheers, Daniel
> ---
>  drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
> index 7159018..0d4e902 100644
> --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
> +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
> @@ -332,13 +332,13 @@ static int hibmc_pci_probe(struct pci_dev *pdev,
>         ret = pcim_enable_device(pdev);
>         if (ret) {
>                 drm_err(dev, "failed to enable pci device: %d\n", ret);
> -               goto err_free;
> +               goto err_return;
>         }
>
>         ret = hibmc_load(dev);
>         if (ret) {
>                 drm_err(dev, "failed to load hibmc: %d\n", ret);
> -               goto err_free;
> +               goto err_return;
>         }
>
>         ret = drm_dev_register(dev, 0);
> @@ -354,9 +354,7 @@ static int hibmc_pci_probe(struct pci_dev *pdev,
>
>  err_unload:
>         hibmc_unload(dev);
> -err_free:
> -       drm_dev_put(dev);
> -
> +err_return:
>         return ret;
>  }
>
> --
> 2.7.4
>


-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch