Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp4958727pxu; Tue, 22 Dec 2020 05:14:12 -0800 (PST) X-Google-Smtp-Source: ABdhPJzP+RkFg5kyB14a70qP/cS/9iN8HAgK23rNMe6tuURBPlerX/n8C7v6RSezjLgzZ517I36O X-Received: by 2002:a17:906:4e45:: with SMTP id g5mr19706487ejw.391.1608642852189; Tue, 22 Dec 2020 05:14:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1608642852; cv=none; d=google.com; s=arc-20160816; b=fbhWawT5ljiI2hhlzSH++Y9XKfkzBIl2QBiF6XuYoWazIvvJsQC1ZLxieXdsHFjT2O Gu5zamLMTgzMsJVaIQ247ijcN/2ItffvLk4Z12GhvCF0NrkhKYhKDMJtCsOhXMMWG2uj tfJ8OuW9nbfGou798Ycm9NE3SnrY7N25tkVCIt7GEKOXZOhH062kC98bndhQwXuh2QQ2 sIb0xru84+Z3OrzhD85nz0eKsozyPm47HVHLLruVgNeqgKE4WZJc2hQF0wGpa2lSxWMW fLlPCAYToSKIppNEzO0EYeZDBOXc5bc5LF3lrJV/pVJ+aWfDGWIJQBtIJw4UtGCFtmvU DB3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:subject:references:in-reply-to :cc:to:from; bh=Grj5yE8Wjr58gX3sUoF1ehxm/f4LKpkNE7fv+unBjNk=; b=pWZwkIQ1ey6CjagCmNGL7Xq0eV0QdoM2Zvsjvz8ecjaKoZzLaMsJF5N599Py2hs+zt 7mc2VfCd2QehWCwZDwf6015BHvh7E9/OWZulBPuP+m3SHccVuze8M9YLAaK/8uuvjLB7 yHTPoqHjC+fEoNZt43jVHJi0IZcEYjPkXLeTmM1w9Nnmg/C7q1igyYLidCzztVQuedJd SpB0q5X7ouux7gPzo82dhcSrq0hY4yuWpEKENye156/YnGWFgrRopO7ribFtmA+PfVUc 5HsGEEd0lkd1OsuUETeeKqZiM86yceuCUCjv4R0VPT9aaecrwVPkx6d+br09RhPt4FRn JnMg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i1si11968145edl.551.2020.12.22.05.13.50; Tue, 22 Dec 2020 05:14:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727389AbgLVNMH (ORCPT + 99 others); Tue, 22 Dec 2020 08:12:07 -0500 Received: from bilbo.ozlabs.org ([203.11.71.1]:46437 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727371AbgLVNME (ORCPT ); Tue, 22 Dec 2020 08:12:04 -0500 Received: by ozlabs.org (Postfix, from userid 1034) id 4D0cDB4BSMz9sWP; Wed, 23 Dec 2020 00:11:22 +1100 (AEDT) From: Michael Ellerman To: Michael Ellerman , Benjamin Herrenschmidt , Christophe Leroy , Paul Mackerras Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org In-Reply-To: References: Subject: Re: [PATCH] powerpc/32: Fix vmap stack - Properly set r1 before activating MMU on syscall too Message-Id: <160864266247.1929899.17670433500031746494.b4-ty@ellerman.id.au> Date: Wed, 23 Dec 2020 00:11:22 +1100 (AEDT) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 21 Dec 2020 06:18:03 +0000 (UTC), Christophe Leroy wrote: > We need r1 to be properly set before activating MMU, otherwise any new > exception taken while saving registers into the stack in syscall > prologs will use the user stack, which is wrong and will even lockup > or crash when KUAP is selected. > > Do that by switching the meaning of r11 and r1 until we have saved r1 > to the stack: copy r1 into r11 and setup the new stack pointer in r1. > To avoid complicating and impacting all generic and specific prolog > code (and more), copy back r1 into r11 once r11 is save onto > the stack. > > [...] Applied to powerpc/fixes. [1/1] powerpc/32: Fix vmap stack - Properly set r1 before activating MMU on syscall too https://git.kernel.org/powerpc/c/d5c243989fb0cb03c74d7340daca3b819f706ee7 cheers