Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201222081057.26401-1-alice.guo@oss.nxp.com> <20201222081057.26401-4-alice.guo@oss.nxp.com>
In-Reply-To: <20201222081057.26401-4-alice.guo@oss.nxp.com>
From:   Fabio Estevam <festevam@gmail.com>
Date:   Tue, 22 Dec 2020 10:25:32 -0300
Message-ID: <CAOMZO5C2L1R1YrnoHL19ztCA5kzOLYQHC2OY2LFi2Lh8sbv24Q@mail.gmail.com>
Subject: Re: [PATCH v9 4/4] soc: imx8m: change to use platform driver
To:     "Alice Guo (OSS)" <alice.guo@oss.nxp.com>
Cc:     Rob Herring <robh+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Sascha Hauer <kernel@pengutronix.de>,
        Krzysztof Kozlowski <krzk@kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@lists.infradead.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        NXP Linux Team <linux-imx@nxp.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Alice,

On Tue, Dec 22, 2020 at 5:11 AM Alice Guo (OSS) <alice.guo@oss.nxp.com> wrote:

> -       soc_uid = readl_relaxed(ocotp_base + OCOTP_UID_HIGH);
> -       soc_uid <<= 32;
> -       soc_uid |= readl_relaxed(ocotp_base + OCOTP_UID_LOW);
> +       if (dev) {
> +               int ret = 0;

No need to initialize ret to 0.

> -       imx8mm_soc_uid();
> +       if (dev) {
> +               int ret = 0;

Ditto.


> +/* Retain device_initcall is for backward compatibility with DTS. */
> +static int __init imx8_soc_init(void)
> +{
> +       int ret = 0;

Ditto.

> +
> +       if (of_find_matching_node_and_match(NULL, imx8_soc_match, NULL))
> +               return 0;
> +
> +       ret = imx8_soc_info(NULL);
> +       return ret;

Or you could even get rid of 'ret' and return imx8_soc_info() directly.