Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp4996386pxu; Tue, 22 Dec 2020 06:06:57 -0800 (PST) X-Google-Smtp-Source: ABdhPJzjUjH4O6keo3Z6gvx1dBSZxxZ8Zs8aXmPdttUKpfVKG0TPsMqLWH9djZuztiK8j1FHZlx9 X-Received: by 2002:a50:e84d:: with SMTP id k13mr20120862edn.154.1608646017409; Tue, 22 Dec 2020 06:06:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1608646017; cv=none; d=google.com; s=arc-20160816; b=JmqGpPXWbCJ2gE0BtEF5a3nDib/Z9JDI4hUovLNuIFqqO47RS7XcpTeHY5sOEGqCSS cqrpcFmUDnlDUf2+u6lSgo8mLahLCSqoL4Shw+ZMn1WIMG0XXHBtTD37VnvLPf3dRGPK hs/zdoYiO2etpQ2iQt1LI2UtY47TgebkmK9I31uy//EeUMkuu08LKcyfr6FpI/39F4KF Zlnhuk0fk7o8/euk5ix5XRzkj8oKYVrlJI+QqUe1qso0YgxsBiaRWb7aFm1dLccJgn8B q36REGd05Rd4Zf6mUGBuBmMaXxJ2kKz4kq0DzrrEPm39kd1q2un84VpmpC3gScqU5N7e 5FYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=DxJqoJ8PnZK608eAZuGRcAj/J+cjWwjqs4ZUdTA2aew=; b=g0+NSbMbeppMg+WNqSAOP21c74+C2jFhPcwa2LGJ+MtLddjBaabB6TY5DH9jc6PwSv FY3qprZDYTywoNF/MfvCpjvxNOJQrc7crRGjcJ2tWz2NcNCSxGWRkQHeGr3t3e+0z4Wo DY67PMDh1ujxhxUVBp3Mth3dfYJQ6UTyL1MknYiUzsNeJyHHpl3OD3YAOpSee+x+8h4i NK9osmFASdvgT0GdDJSzW/HRAyeKCGUuOkPq29JvLQdGJ2gqs3M+GF6PMfT2myx20Dmq /p5qTy8F6u+AhFjYozUGFb9Dsx8cWxJFrPxp9R7ZOa2gRwVU1UW8nrRXytbaxyvttRyB 8cgQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=Wk0QyNPy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g24si6520490edu.156.2020.12.22.06.06.34; Tue, 22 Dec 2020 06:06:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=Wk0QyNPy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727292AbgLVOFh (ORCPT + 99 others); Tue, 22 Dec 2020 09:05:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35892 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726868AbgLVOFh (ORCPT ); Tue, 22 Dec 2020 09:05:37 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF997C0613D3; Tue, 22 Dec 2020 06:04:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=DxJqoJ8PnZK608eAZuGRcAj/J+cjWwjqs4ZUdTA2aew=; b=Wk0QyNPy3C7mnC8JzcEbs7bvSx ozNMMdU8xG2atPmKs5376oVfRxkJIVdFdrKtl2H+yVycLYEyCN5/KErhmQ7HlYH5spEQ+OBxzePES fzTTHU4psBg+4K1MNT4mWu1vr+rUS9JyISGryO9MeVUuq1zXfuiu/N2BfoJ/tDz2xip/4liR36iwG U4xmkNIHV9G8zFqFtZbkduhNh2YrClKJ1TG+drl9Nl9/1tfWcxO+pbSoRciPdzOEaRhwSv8RRU0FQ tGul94ouWAU8VpNmAsLvphJ0llkmVPz4nUXj2PHJJYkjHiHLESJo6fSQww5RaGcZmBT3Z/4Nc90k+ CBkCCo9A==; Received: from hch by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kriHX-0003Xe-5N; Tue, 22 Dec 2020 14:04:55 +0000 Date: Tue, 22 Dec 2020 14:04:55 +0000 From: Christoph Hellwig To: Pavel Begunkov Cc: linux-block@vger.kernel.org, Jens Axboe , Christoph Hellwig , Matthew Wilcox , Ming Lei , Johannes Weiner , Alexander Viro , "Darrick J . Wong" , "Martin K . Petersen" , Jonathan Corbet , linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, io-uring@vger.kernel.org, linux-kernel@vger.kernel.org, target-devel@vger.kernel.org, linux-scsi@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH v1 3/6] bio: deduplicate adding a page into bio Message-ID: <20201222140455.GB13079@infradead.org> References: <189cae47946fa49318f85678def738d358e8298b.1607976425.git.asml.silence@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <189cae47946fa49318f85678def738d358e8298b.1607976425.git.asml.silence@gmail.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If it was up to me I'd shorten noaccount to noacct. Otherwise looks good: Reviewed-by: Christoph Hellwig