Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp4999248pxu;
        Tue, 22 Dec 2020 06:09:52 -0800 (PST)
X-Google-Smtp-Source: ABdhPJx0Aj2BAmDxsfRQxcXlnM1jME+Mi06Y9zTy/XrIAlFXKWyGWPHEWS62erMNL4Op0dpkpEew
X-Received: by 2002:a17:906:e250:: with SMTP id gq16mr19331781ejb.382.1608646192260;
        Tue, 22 Dec 2020 06:09:52 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1608646192; cv=none;
        d=google.com; s=arc-20160816;
        b=gC/k+dGgG9dE0E1YFKUil/4efQB/0RCXAUWu4Y8QSnlJj4iZxRq+aSf41+pVygKAHk
         41MFb1ufoogAJbBlBJ8qLlVQmCvwKgzK9qQnBs/gLEm635FhoZMPX5UeURY8/wV2TAlQ
         Zz5+8hdd9dd9Jx+6nq0Jviuy8uHu/UaTYeOkjTZo0ybUR69o0X3WPDeTab1zgvtIHctt
         /de6sLXO49dgzaAGzixi61WsjnA10+tPtxNkrb0kvj35vlHXH+1sulUA3lQp+sCjdZRj
         5VTr70mUDNlGWjr5m4sbFhBEHg2GfUMcLMjgtcnJhlXq6IUQJX3SVoOcTikdYdMe/huV
         Toxw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:in-reply-to:content-disposition:mime-version
         :references:message-id:subject:cc:to:from:date:dkim-signature;
        bh=XnsEBHKmuwIqwZw9cYL0vV1Aq/iIMWLNA0XSZ9mrSbg=;
        b=U3Rus3xDOoDb4XEmDe6Xd3E+omJP4e5NBlIqCWNNIAodOE/3wGr8QJNkUizKFk2N3l
         lbaoen2kUP9+dNpltHgRwl0EZaWveKX/GLygxDwyANtNRBvavYugWJsz/apZMT2ZlR7D
         DUUAsbY+u5CW1l0qCGvZ/k3O4ia9CMDMmICjqV7sBsFRI1yLHiUySp4PH5S8M2aSLwta
         bFFYB3c6ZYvAr0O4cEQ6S3Ao1wrpqwGAsU9+Qg/2RILo/n6bKdmi1p4+KZGD6d+nGqKL
         9PHCY+C9TA41EURk19I4xsp1MMwkaWQM7Z87JYQ7xQm2c+Ov7Yq1Jbk9eOf4q7wtRIrQ
         3tDw==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=exJwyhWY;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id n25si11817919edy.231.2020.12.22.06.09.27;
        Tue, 22 Dec 2020 06:09:52 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=exJwyhWY;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727608AbgLVOId (ORCPT <rfc822;lonelydragon1988@gmail.com>
        + 99 others); Tue, 22 Dec 2020 09:08:33 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36344 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1727155AbgLVOIc (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 22 Dec 2020 09:08:32 -0500
Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C40C9C0613D6;
        Tue, 22 Dec 2020 06:07:51 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
        d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version:
        References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:
        Content-Transfer-Encoding:Content-ID:Content-Description;
        bh=XnsEBHKmuwIqwZw9cYL0vV1Aq/iIMWLNA0XSZ9mrSbg=; b=exJwyhWYmapTVxVLc5bGLvtE5d
        xNeJhmtHOFCQYPhZZMbrj1Ak3HZx014+BylUYe7e0y8E9Mp622pTlvwASCIsDdeSCsmv7Lmh0HL48
        8Qvm6gTQ62jKNPVvB64/PWV5SXme9lhmsN6iKgQXb6xkjUU4JJBBIJVcWczeB+bQXigaU2wrfmq4J
        YDvm5bgdc9w7SthjP+9MyxnOObP8X7yhLPflUnvdtXHdmUK0pqARb+tVbqkogWDOBLAXOZih3JCl/
        a9CfEss5uumx4/GKG2GjX/Z85bS4vzfdbYjk/2RaExluvXl0hjN6Qvn8uex3sNRp8PGNUWp4mBmlE
        4HKPrHvA==;
Received: from hch by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux))
        id 1kriKL-0003nr-Mv; Tue, 22 Dec 2020 14:07:49 +0000
Date:   Tue, 22 Dec 2020 14:07:49 +0000
From:   Christoph Hellwig <hch@infradead.org>
To:     Pavel Begunkov <asml.silence@gmail.com>
Cc:     linux-block@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
        Christoph Hellwig <hch@infradead.org>,
        Matthew Wilcox <willy@infradead.org>,
        Ming Lei <ming.lei@redhat.com>,
        Johannes Weiner <hannes@cmpxchg.org>,
        Alexander Viro <viro@zeniv.linux.org.uk>,
        "Darrick J . Wong" <darrick.wong@oracle.com>,
        "Martin K . Petersen" <martin.petersen@oracle.com>,
        Jonathan Corbet <corbet@lwn.net>, linux-xfs@vger.kernel.org,
        linux-fsdevel@vger.kernel.org, io-uring@vger.kernel.org,
        linux-kernel@vger.kernel.org, target-devel@vger.kernel.org,
        linux-scsi@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH v1 5/6] bio: add a helper calculating nr segments to alloc
Message-ID: <20201222140749.GD13079@infradead.org>
References: <cover.1607976425.git.asml.silence@gmail.com>
 <94b6f76d2d47569742ee47caede1504926f9807a.1607976425.git.asml.silence@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <94b6f76d2d47569742ee47caede1504926f9807a.1607976425.git.asml.silence@gmail.com>
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by casper.infradead.org. See http://www.infradead.org/rpr.html
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The new helper needs a comment explaining the use case.

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>