Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 22 Dec 2020 15:15:17 +0100
Message-ID: <s5hmty6dj0q.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Ravulapati Vishnu vardhan rao 
        <Vishnuvardhanrao.Ravulapati@amd.com>
Cc:     <Alexander.Deucher@amd.com>, Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        Jaroslav Kysela <perex@perex.cz>,
        "Takashi Iwai" <tiwai@suse.com>,
        Akshu Agrawal <akshu.agrawal@amd.com>,
        Dan Carpenter <dan.carpenter@oracle.com>,
        Vijendar Mukunda <Vijendar.Mukunda@amd.com>,
        "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." 
        <alsa-devel@alsa-project.org>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ASoC: amd:Replacing MSI with Legacy IRQ model
In-Reply-To: <20201222115929.11222-1-Vishnuvardhanrao.Ravulapati@amd.com>
References: <20201222115929.11222-1-Vishnuvardhanrao.Ravulapati@amd.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Tue, 22 Dec 2020 12:59:18 +0100,
Ravulapati Vishnu vardhan rao wrote:
> 
> When we try to play and capture simultaneously we see that
> interrupts are genrated but our handler is not being acknowledged,
> After investigating further more in detail on this issue we found
> that IRQ delivery via MSI from the ACP IP is unreliable and so sometimes
> interrupt generated will not be acknowledged so MSI model shouldn't be used
> and using legacy IRQs will resolve interrupt handling issue.
> 
> This patch replaces MSI interrupt handling with legacy IRQ model.
> 
> Issue can be reproduced easily by running below python script:
> 
> import subprocess
> import time
> import threading
> 
> def do2():
>   cmd = 'aplay -f dat -D hw:2,1 /dev/zero -d 1'
>     subprocess.call(cmd, stdin=subprocess.PIPE,
> 			stderr=subprocess.PIPE, shell=True)
>     print('Play Done')
> 
> def run():
> 	for i in range(1000):
> 		do2()
> 
> def do(i):
>     cmd = 'arecord -f dat -D hw:2,2 /dev/null -d 1'
>     subprocess.call(cmd, stdout=subprocess.PIPE,
> 			stderr=subprocess.PIPE, shell=True)
>     print(datetime.datetime.now(), i)
> 
> t = threading.Thread(target=run)
> t.start()
> for i in range(1000):
> 	do(i)
> 
> t.join()
> 
> After applying this patch issue is resolved.
> 
> Signed-off-by: Ravulapati Vishnu vardhan rao <Vishnuvardhanrao.Ravulapati@amd.com>

Is this specific to Raven, i.e. Renoir doesn't need the same fix?
If so, it should be mentioned in the patch description.


thanks,

Takashi