Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp5033074pxu; Tue, 22 Dec 2020 06:55:15 -0800 (PST) X-Google-Smtp-Source: ABdhPJzApioYEnGWSVkkd1oUt5JN1HETzielmSx+e8IvPEEY02ITRVZOxw+TJ3XyKEj6NdLqbT2h X-Received: by 2002:a17:906:234d:: with SMTP id m13mr20281089eja.270.1608648915214; Tue, 22 Dec 2020 06:55:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1608648915; cv=none; d=google.com; s=arc-20160816; b=jSCuXakUrI1c4BKI1WvYVwouGs3I7XcslHNfKVdolK4tY1VzhDyAZoOb8X/dL7ALdO 8XztX5eMJm2BB75TEtrPIUIOF0Ruw05DQqHmqt8xAULuEqSY1cEpZKi5qs4iW3IX6HsU 0bGgji7X7Lyx2UvDcNbGbdF7fyKlmeVJVVHyN2OCPlVerIBhsIu3nzSj5q4+C25ZmkkE trORRRJ417KiWBSC2ijUz4+kq0ET47cpKldLdzGJvD6v+ZT8DGP4SNqC+NVNvdHsBdk5 jLvYMFYAsF1SJfFxc8rjmZXwT/XGdZR14nwpRPuqB6YZhtOkrWsd9zBxPK4DPCdURYNN nixg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=0yQ8UYqXYhuWeo88yhwpae0/ouSJbgBQji4T5APlSZo=; b=AKhst9z/qnlgtGSRd/l2uEQC94zmDvEd5d2g+WSAyA2THHN1egRTs6odhgC4b8mT9i 5sQc0XsFyHD8e6BCsI0S9oYiXusrOGsWDtKdMIbIHCNooQ3b+4zteULL0VkwcBR2Zg1w BxIkwgsUGn1rFKeoQyjFHNBMi20DlHlXKoKb0Dx0UegBYQQ21BTHHkBYXED/eWukG+H1 jnm6NmvWMlQAVwenUk9PSdov3wJv3Mwt971XWoEEn8KLBX0ArAUJAMwUU1Earh6FBpgE YsQnQyxK+XUifMTPooxBeLSRKgroViM/+3ylbdW00pMSZ9z3YLPlMhiaMzJjKnv6ls/H p+IQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=lJcTKd0y; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o6si10751202ejj.354.2020.12.22.06.54.52; Tue, 22 Dec 2020 06:55:15 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=lJcTKd0y; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727448AbgLVOwX (ORCPT + 99 others); Tue, 22 Dec 2020 09:52:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43122 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727172AbgLVOwW (ORCPT ); Tue, 22 Dec 2020 09:52:22 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4E6EEC0613D3 for ; Tue, 22 Dec 2020 06:51:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=0yQ8UYqXYhuWeo88yhwpae0/ouSJbgBQji4T5APlSZo=; b=lJcTKd0y1qgaGiy6Xvw8aQkzsN tl8FNYsXi9WQht26DlkWcH12TWUtegtaNDHLtiiW79CwVUicw5/u4SSNOAzB+Y7jE/w6fKPChOAx7 9AbuP0fhQTja6ZjKRCainCiAbfnrU5jQCVnQLEYYQiTqPIe517eRvDF2eALdVo2TYo7j33A2us2Le RZW2/IXi8V+GFpmYehzHHJ9SADstknPLqUmAT2MFEo+LQOafP+Uc6vTiPVpzEsRY/hHWOUkaotDpK u94rkoJwDguo5d7Qhk//ZpLiwjkoyAeLPxQPVCFYs+xqW8ukmyUkGJnxXFx4MN0POQII4gjq4XbsN fytn2dMw==; Received: from hch by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1krj0k-0006s1-FV; Tue, 22 Dec 2020 14:51:38 +0000 Date: Tue, 22 Dec 2020 14:51:38 +0000 From: Christoph Hellwig To: Adrian Huang Cc: linux-kernel@vger.kernel.org, x86@kernel.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H . Peter Anvin" , Adrian Huang Subject: Re: [PATCH 1/1] x86/mm: Refine mmap syscall implementation Message-ID: <20201222145138.GA25752@infradead.org> References: <20201217052648.24656-1-adrianhuang0701@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201217052648.24656-1-adrianhuang0701@gmail.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 17, 2020 at 01:26:48PM +0800, Adrian Huang wrote: > From: Adrian Huang > > It is unnecessary to use the local variable 'error' in the mmap > syscall implementation function, so use the return statement > instead of it. I'm normally not a fan of standalone cleanup patches, but this one actually improves the function a lot, so: Reviewed-by: Christoph Hellwig