Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 22 Dec 2020 15:07:43 +0000
To:     Bjorn Helgaas <bhelgaas@google.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
From:   Alexander Lobakin <alobakin@pm.me>
Cc:     Jingoo Han <jingoohan1@gmail.com>,
        Gustavo Pimentel <gustavo.pimentel@synopsys.com>,
        Rob Herring <robh@kernel.org>, Vidya Sagar <vidyas@nvidia.com>,
        Robin Murphy <robin.murphy@arm.com>,
        Alexander Lobakin <alobakin@pm.me>, linux-pci@vger.kernel.org,
        linux-kernel@vger.kernel.org
Reply-To: Alexander Lobakin <alobakin@pm.me>
Subject: [PATCH pci] PCI: dwc: fix inverted condition of DMA mask setup warning
Message-ID: <20201222150708.67983-1-alobakin@pm.me>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Commit 660c486590aa ("PCI: dwc: Set 32-bit DMA mask for MSI target
address allocation") added dma_mask_set() call to explicitly set
32-bit DMA mask for MSI message mapping, but for now it throws a
warning on ret =3D=3D 0, while dma_set_mask() returns 0 in case of
success.
Fix this by inverting the condition.

Misc: remove redundant braces around single statement.

Fixes: 660c486590aa ("PCI: dwc: Set 32-bit DMA mask for MSI target address =
allocation")
Signed-off-by: Alexander Lobakin <alobakin@pm.me>
---
 drivers/pci/controller/dwc/pcie-designware-host.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pc=
i/controller/dwc/pcie-designware-host.c
index 516b151e0ef3..fa40cc2e376f 100644
--- a/drivers/pci/controller/dwc/pcie-designware-host.c
+++ b/drivers/pci/controller/dwc/pcie-designware-host.c
@@ -397,12 +397,11 @@ int dw_pcie_host_init(struct pcie_port *pp)
 =09=09=09=09=09=09=09    pp);
=20
 =09=09=09ret =3D dma_set_mask(pci->dev, DMA_BIT_MASK(32));
-=09=09=09if (!ret) {
+=09=09=09if (ret)
 =09=09=09=09dev_warn(pci->dev,
 =09=09=09=09=09 "Failed to set DMA mask to 32-bit. "
 =09=09=09=09=09 "Devices with only 32-bit MSI support"
 =09=09=09=09=09 " may not work properly\n");
-=09=09=09}
=20
 =09=09=09pp->msi_data =3D dma_map_single_attrs(pci->dev, &pp->msi_msg,
 =09=09=09=09=09=09      sizeof(pp->msi_msg),
--=20
2.29.2