Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp5052780pxu; Tue, 22 Dec 2020 07:18:36 -0800 (PST) X-Google-Smtp-Source: ABdhPJwK+i9YqfYVBBkWdZk9l45zFntGGw/bsNc8aiWvfW0gBWKyd0esUO3IeZODFeE5mGRj5/bs X-Received: by 2002:a50:b765:: with SMTP id g92mr20723242ede.317.1608650316728; Tue, 22 Dec 2020 07:18:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1608650316; cv=none; d=google.com; s=arc-20160816; b=Hzm0E1oSltbNm9HJvCIslf1C+PMSz5B36tEiaPOuLXnHN6ZZiS7YDwuvjC1wGqSGuh U3e97n/uS3QWbP8hUKubbtvBmWZ0ab23eFviGcap7K0pj9u8T5cAoJ3VzbC6vXjJwrMJ VmZ2GA9gZJnYewgV+AkTobmKueie643gCe4E0iw6HcPsmwYnE/W80tmwaomwns4Pe7og a3BYH40JHPrpP5i7RLhM9DSG+kuMQTloEPECR0ftqpY6rL7awj0/FOjxo3lK8BcsW245 PMDAAGCT8PtRCETHsMG7OM9NrGmPxGPW3TpXquiASwaNGuNtMTapHj0iZJ4Jv3nkTMi1 5P+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=vFVTJ+0eHU766NlPjzayRjSs+Vk0hqn0SrA9Il/j3JU=; b=g6k5s0AGqqe9RIT7k2cum0/jWkx7V/H49H4obPO67jnVpS0HvEXoR8PROjUb3OZnY6 0xuWLYZ1PHxFvgq0HK1ZnVFoyaRjF8+ZeTLuLbHGx1tjp3oDOKTnHZ13e9Yz5JPy9Gch 0lpi3zbE65vo0Ee7IADXP61l+eTQ1C46HEjUlFoAczLCbxPw/xv3x3ps9rqbdvacBbHP 9y1AlrTsPTYlc7eKVYBzDDs+NYJ7NBl5xG9v38kOuTYRrxgnVgAxaSaJKx1pLR9dJ1E2 9hZTTA0WoJ+u4YGLz7UcfJVuhP60G34zRUvTV68EUehaTmRU5e4bn4Cp/Vy4usRcl4vJ gAEw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=sSZ3NgXR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id qn10si10727362ejb.591.2020.12.22.07.18.13; Tue, 22 Dec 2020 07:18:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=sSZ3NgXR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727883AbgLVPQ6 (ORCPT + 99 others); Tue, 22 Dec 2020 10:16:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47042 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727301AbgLVPQ6 (ORCPT ); Tue, 22 Dec 2020 10:16:58 -0500 Received: from mail-il1-x12f.google.com (mail-il1-x12f.google.com [IPv6:2607:f8b0:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CD461C0613D3 for ; Tue, 22 Dec 2020 07:16:17 -0800 (PST) Received: by mail-il1-x12f.google.com with SMTP id n9so12324591ili.0 for ; Tue, 22 Dec 2020 07:16:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=vFVTJ+0eHU766NlPjzayRjSs+Vk0hqn0SrA9Il/j3JU=; b=sSZ3NgXR3fJvfO5KGnv/psaGcLEYQx0ftL8WbaYkt8YldWrlXDxO++LjxIQlaQp2Gc OgeLUUG3UQ2h2zHrrl3apTSKHaGHKooKuTysvMaGtrWMsGBMFVHJzrzJank70A3eNjRE VE0x6tKeooyjNNQzhdzDM8H5Hcp85GyoldwT3wfua1IK6NehDHUti7oaQ8+DgzV0gFUA pB0OJ8mYiHHYhJfiVti+d93k7FG3ri+F2MxaCtnXXVM9YFBF6K4CM9HGJavi4cDbVGbm DWjzXdINbuB/YhGtk8jPzqwbAmzRq/4d+f79gnv67on9zioICf8uxrHr4QFwZH2wRIJv LExw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=vFVTJ+0eHU766NlPjzayRjSs+Vk0hqn0SrA9Il/j3JU=; b=OOuHdUAhVjq0HJxyp2EOyzZv3NjP1UxeipRdS1Hj/b8NFKy9wud/9LjnZTA27uP4VF zud+0TdLpz2R+r8rw0KcxZZrgHEDtMKfVLiij1w37SCMt6FXQ9qBxjjyWrG0cXPc8u7g iUSkJxiqvEK2gG6NlzHR6hme+HWTGGRPiUdC9fbMXva6RJy/LnuPiXVogT15j7cjc8OE 866AQMYQauxgcEULfDhRYz+krvziS11KZCsvU+i3jenfT1tez/DAwyW/cI/CDWb9K0ui M5oU/1KSyZN83FUqkfQMDYs9G9dua4ITvQdt74LFN1wDCbg1Ot9NTfhXtp/of5XQK7cG m04Q== X-Gm-Message-State: AOAM531IjjKnuoeZMP4sD1ZDggNmvXehc34fjtYZPhDXaUEfaWLUB2dV 8of9b4zSmlP85ELx5D52huq5ig== X-Received: by 2002:a05:6e02:1bcb:: with SMTP id x11mr20217449ilv.32.1608650177174; Tue, 22 Dec 2020 07:16:17 -0800 (PST) Received: from beast.localdomain (c-73-185-129-58.hsd1.mn.comcast.net. [73.185.129.58]) by smtp.gmail.com with ESMTPSA id e25sm24018458iom.40.2020.12.22.07.16.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Dec 2020 07:16:16 -0800 (PST) From: Alex Elder To: davem@davemloft.net, kuba@kernel.org Cc: evgreen@chromium.org, cpratapa@codeaurora.org, bjorn.andersson@linaro.org, subashab@codeaurora.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net] net: ipa: fix interconnect enable bug Date: Tue, 22 Dec 2020 09:16:13 -0600 Message-Id: <20201222151613.5730-1-elder@linaro.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When the core clock rate and interconnect bandwidth specifications were moved into configuration data, a copy/paste bug was introduced, causing the memory interconnect bandwidth to be set three times rather than enabling the three different interconnects. Fix this bug. Fixes: 91d02f9551501 ("net: ipa: use config data for clocking") Signed-off-by: Alex Elder --- drivers/net/ipa/ipa_clock.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ipa/ipa_clock.c b/drivers/net/ipa/ipa_clock.c index 9dcf16f399b7a..135c393437f12 100644 --- a/drivers/net/ipa/ipa_clock.c +++ b/drivers/net/ipa/ipa_clock.c @@ -115,13 +115,13 @@ static int ipa_interconnect_enable(struct ipa *ipa) return ret; data = &clock->interconnect_data[IPA_INTERCONNECT_IMEM]; - ret = icc_set_bw(clock->memory_path, data->average_rate, + ret = icc_set_bw(clock->imem_path, data->average_rate, data->peak_rate); if (ret) goto err_memory_path_disable; data = &clock->interconnect_data[IPA_INTERCONNECT_CONFIG]; - ret = icc_set_bw(clock->memory_path, data->average_rate, + ret = icc_set_bw(clock->config_path, data->average_rate, data->peak_rate); if (ret) goto err_imem_path_disable; -- 2.20.1