Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH net] net: ipa: fix interconnect enable bug
To:     Alex Elder <elder@linaro.org>, davem@davemloft.net, kuba@kernel.org
Cc:     evgreen@chromium.org, cpratapa@codeaurora.org,
        bjorn.andersson@linaro.org, subashab@codeaurora.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20201222151613.5730-1-elder@linaro.org>
From:   Georgi Djakov <georgi.djakov@linaro.org>
Message-ID: <9601b599-3edb-8fff-5b22-904cca62fbda@linaro.org>
Date:   Tue, 22 Dec 2020 18:18:31 +0200
MIME-Version: 1.0
In-Reply-To: <20201222151613.5730-1-elder@linaro.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 12/22/20 17:16, Alex Elder wrote:
> When the core clock rate and interconnect bandwidth specifications
> were moved into configuration data, a copy/paste bug was introduced,
> causing the memory interconnect bandwidth to be set three times
> rather than enabling the three different interconnects.
> 
> Fix this bug.
> 
> Fixes: 91d02f9551501 ("net: ipa: use config data for clocking")
> Signed-off-by: Alex Elder <elder@linaro.org>

Reviewed-by: Georgi Djakov <georgi.djakov@linaro.org>

> ---
>   drivers/net/ipa/ipa_clock.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ipa/ipa_clock.c b/drivers/net/ipa/ipa_clock.c
> index 9dcf16f399b7a..135c393437f12 100644
> --- a/drivers/net/ipa/ipa_clock.c
> +++ b/drivers/net/ipa/ipa_clock.c
> @@ -115,13 +115,13 @@ static int ipa_interconnect_enable(struct ipa *ipa)
>   		return ret;
>   
>   	data = &clock->interconnect_data[IPA_INTERCONNECT_IMEM];
> -	ret = icc_set_bw(clock->memory_path, data->average_rate,
> +	ret = icc_set_bw(clock->imem_path, data->average_rate,
>   			 data->peak_rate);
>   	if (ret)
>   		goto err_memory_path_disable;
>   
>   	data = &clock->interconnect_data[IPA_INTERCONNECT_CONFIG];
> -	ret = icc_set_bw(clock->memory_path, data->average_rate,
> +	ret = icc_set_bw(clock->config_path, data->average_rate,
>   			 data->peak_rate);
>   	if (ret)
>   		goto err_imem_path_disable;
>