Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965104AbWIEP0P (ORCPT ); Tue, 5 Sep 2006 11:26:15 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965111AbWIEP0O (ORCPT ); Tue, 5 Sep 2006 11:26:14 -0400 Received: from mx2.suse.de ([195.135.220.15]:50349 "EHLO mx2.suse.de") by vger.kernel.org with ESMTP id S965104AbWIEP0L (ORCPT ); Tue, 5 Sep 2006 11:26:11 -0400 Date: Tue, 05 Sep 2006 17:26:03 +0200 Message-ID: From: Takashi Iwai To: Pavel Machek Cc: "Randy.Dunlap" , Andrew Morton , kernel list , perex@suse.cz, alsa-devel@alsa-project.org, pshou@realtek.com.tw Subject: Re: CodingStyle (was: Re: sound/pci/hda/intel_hda: small cleanups) In-Reply-To: <20060905080813.GE1958@elf.ucw.cz> References: <20060831123706.GC3923@elf.ucw.cz> <20060831110436.995bdf93.rdunlap@xenotime.net> <20060902231509.GC13031@elf.ucw.cz> <20060902213046.dd9bf569.rdunlap@xenotime.net> <20060905080813.GE1958@elf.ucw.cz> User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 MULE XEmacs/21.5 (beta25) (eggplant) (+CVS-20060326) (i386-suse-linux) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1132 Lines: 42 At Tue, 5 Sep 2006 10:08:14 +0200, Pavel Machek wrote: > > > > Looks reasonable to me. Will you do the patch or should I ? > > > > Please (you) go ahead with it. > > Does it look okay? > > Signed-off-by: Pavel Machek > > diff --git a/Documentation/CodingStyle b/Documentation/CodingStyle > index 6d2412e..d8e51a6 100644 > --- a/Documentation/CodingStyle > +++ b/Documentation/CodingStyle > @@ -46,6 +46,16 @@ used for indentation, and the above exam > > Get a decent editor and don't leave whitespace at the end of lines. > > +Bitfield variables should be indented like this: > + > + unsigned int foo :1; > + > +Avoid extra spaces around ! operator, and do not place spaces around (s. > + > + if (!buffer) > + > +is okay, if ( ! buffer ) is just ugly. > + I know I belong to an endagered species, but I still find if (! buffer) ... isn't so ugly. Takashi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/