Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2 43/48] ARM: tegra: Add OPP tables and power domains to
 Tegra20 device-tree
To:     Viresh Kumar <viresh.kumar@linaro.org>
Cc:     Thierry Reding <thierry.reding@gmail.com>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        Mark Brown <broonie@kernel.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Ulf Hansson <ulf.hansson@linaro.org>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Peter Geis <pgwipeout@gmail.com>,
        Nicolas Chauvet <kwizart@gmail.com>,
        Krzysztof Kozlowski <krzk@kernel.org>,
        "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Kevin Hilman <khilman@kernel.org>,
        Peter De Schrijver <pdeschrijver@nvidia.com>,
        Viresh Kumar <vireshk@kernel.org>,
        Stephen Boyd <sboyd@kernel.org>,
        Michael Turquette <mturquette@baylibre.com>,
        devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
        linux-media@vger.kernel.org, linux-tegra@vger.kernel.org,
        linux-clk@vger.kernel.org
References: <20201217180638.22748-1-digetx@gmail.com>
 <20201217180638.22748-44-digetx@gmail.com>
 <20201222054745.2am4bcbk5df5aqzj@vireshk-i7>
From:   Dmitry Osipenko <digetx@gmail.com>
Message-ID: <e3ed3b17-b549-860b-1dc2-cb1d6eb3b90b@gmail.com>
Date:   Tue, 22 Dec 2020 22:24:33 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.4.2
MIME-Version: 1.0
In-Reply-To: <20201222054745.2am4bcbk5df5aqzj@vireshk-i7>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

22.12.2020 08:47, Viresh Kumar пишет:
> On 17-12-20, 21:06, Dmitry Osipenko wrote:
>> diff --git a/arch/arm/boot/dts/tegra20-peripherals-opp.dtsi b/arch/arm/boot/dts/tegra20-peripherals-opp.dtsi
>> index b84afecea154..7e015cdfbc55 100644
>> --- a/arch/arm/boot/dts/tegra20-peripherals-opp.dtsi
>> +++ b/arch/arm/boot/dts/tegra20-peripherals-opp.dtsi
>> @@ -1,6 +1,46 @@
>>  // SPDX-License-Identifier: GPL-2.0
>>  
>>  / {
>> +	core_opp_table: core-power-domain-opp-table {
>> +		compatible = "operating-points-v2";
>> +		opp-shared;
>> +
>> +		core_opp_950: opp@950000 {
>> +			opp-microvolt = <950000 950000 1300000>;
>> +			opp-level = <950000>;
>> +		};
> 
> I am not sure I fully understand this, why does it have both microvolt and level
> properties ?
> 

The level is used by everything related to GENPD, while voltage is used
by the domain driver.

I think it's cleaner to separate the level from voltage, even though
they are set to the same values, which is done purely for convenience.
The 0,1,2,3 levels are meaningless in the context of this power domain,
while voltages make total sense.