Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965064AbWIEQF1 (ORCPT ); Tue, 5 Sep 2006 12:05:27 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965102AbWIEQF1 (ORCPT ); Tue, 5 Sep 2006 12:05:27 -0400 Received: from e36.co.us.ibm.com ([32.97.110.154]:60387 "EHLO e36.co.us.ibm.com") by vger.kernel.org with ESMTP id S965064AbWIEQF0 (ORCPT ); Tue, 5 Sep 2006 12:05:26 -0400 Message-ID: <44FDA024.7030700@in.ibm.com> Date: Tue, 05 Sep 2006 21:34:52 +0530 From: Balbir Singh Reply-To: balbir@in.ibm.com Organization: IBM India Private Limited User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.6) Gecko/20060730 SeaMonkey/1.0.4 MIME-Version: 1.0 To: Kirill Korotaev Cc: Andrew Morton , Rik van Riel , CKRM-Tech , Linux Kernel Mailing List , Andi Kleen , Christoph Hellwig , Andrey Savochkin , Alan Cox , Hugh Dickins , Matt Helsley , Alexey Dobriyan , Oleg Nesterov , devel@openvz.org, Pavel Emelianov Subject: Re: [ckrm-tech] [PATCH 5/13] BC: user interface (syscalls) References: <44FD918A.7050501@sw.ru> <44FD9699.705@sw.ru> In-Reply-To: <44FD9699.705@sw.ru> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 905 Lines: 28 > + > +asmlinkage long sys_set_bcid(bcid_t id) > +{ > + int error; > + struct beancounter *bc; > + struct task_beancounter *task_bc; > + > + task_bc = ¤t->task_bc; I was playing around with the bc patches and found that to make use of bc's, I had to actually call set_bcid() and then exec() a task/shell so that the id would stick around. Would you consider changing sys_set_bcid to sys_set_task_bcid() or adding a new system call sys_set_task_bcid()? We could pass the pid that we intend to associate with the new id. This also means we'll need locking around to protect task->task_bc. -- Balbir Singh, Linux Technology Center, IBM Software Labs - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/