Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp5418756pxu; Tue, 22 Dec 2020 17:13:19 -0800 (PST) X-Google-Smtp-Source: ABdhPJwM2q3QpwpsWMM1mmXTsK8DN4bJE5bj67Bw7AMqK2Zg1r/14reprbwQSRxjt13RkU/0+DzU X-Received: by 2002:a17:906:b74b:: with SMTP id fx11mr22226670ejb.410.1608685998959; Tue, 22 Dec 2020 17:13:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1608685998; cv=none; d=google.com; s=arc-20160816; b=nEarrpR3JEUr6Y5ebVw9nIziXH6S1Q5R+aaK/rn9kqfTu+mic+G6/zL3tbQqbh+238 5SjorC32Ox0VuAs36F69sh9mR9IhsWxqZuadBnaHMDaw7R5+5Z101JzyoxgcHooaAQrJ KHVf0/qbElhgP07T+jV/RLFeAaQuqf+xqj1OEY1rvmr7m0Qy0tlCXT1hVYkbTG8ek+av 5dYBRGe84/usukaHgdNC+MMEAGRQqXulbuk/ZRDvqgSek4qGCtpSOi+D4UTlE96vEyYN 9QTunJlnjBGEE0xDyEON1JR8uIySWMeFPb35UvvhKnL7Il8Sfr1gf0NPmTIQ0SxOCill 6n6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:in-reply-to:subject :cc:to:from:user-agent:references:dkim-signature; bh=9I2ktiRW2omCj6P9wL6twEhofLLfLCizYSj7nwFz7UM=; b=q8Emk4s47G9rBVeiYnE6MFOM91GLsCqM6lRjwgTQ88VnJR+hSQoNXFkuTvVG8PGp+a hf1Gjx3Bcned+2Qyw9TH+D2g8WTWm98jMkuGT5Vvaob5qgd3mFY6sobMTNHtrHA1Xeb5 fXvaL+CHfBShkN8GanBsIpVH1cJT9r3Ka1KHcoFBtbGW3WNOZ6LJdKlankD/pDpRaKgb u9QH7JeeegtWa1P9mNSlk0piyNtd5I6G6/aUHRRCzBcdNkKWf+gP9yspQmReNhVh3Awy cMnGGwJ/0dNjIcyPwzF3y3OUn2B8B0QWcsEaW8pXoDclM26a+DG1tDsUpZDh+AMXios0 J51Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=kiKFSpAl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r10si12689251edy.187.2020.12.22.17.12.56; Tue, 22 Dec 2020 17:13:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=kiKFSpAl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726608AbgLWBMb (ORCPT + 99 others); Tue, 22 Dec 2020 20:12:31 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:10472 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726319AbgLWBMa (ORCPT ); Tue, 22 Dec 2020 20:12:30 -0500 Received: from pps.filterd (m0098393.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 0BN13iRw051130; Tue, 22 Dec 2020 20:11:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=references : from : to : cc : subject : in-reply-to : date : message-id : mime-version : content-type; s=pp1; bh=9I2ktiRW2omCj6P9wL6twEhofLLfLCizYSj7nwFz7UM=; b=kiKFSpAl4VUXC5L8Sn67vd9xqXE+cvVwAqnPfiDfGhsfBodsX7v6Pk/1OSHvuPLfXxIf d6oP3+ULkQWeMieIqytf02E5kItARmEWUSiEykSCCMt8UMhmyFjwjKN6lZ37st+Px4l3 PXMCkG+8uGvF+3rREhe8+sB/NF0oDNoUr7cQTEISU56z+N7TAZQdViEOI6DxLwyLFTqx Ktg+xxzQHs9GOTdvDPk2+6zvOWWUH9CV9uNIN2ysa6xiEjXB18aDJIgK37nWGz7Lkibe WeZQ7FtPflbPhZZrIesT5+0AarPGdaufHs8jsoy1Jm9AbKpXcIhP5hcobYvcc0jgigJs +g== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 35kuqx8c9d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 22 Dec 2020 20:11:21 -0500 Received: from m0098393.ppops.net (m0098393.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 0BN13ohB051823; Tue, 22 Dec 2020 20:11:21 -0500 Received: from ppma04wdc.us.ibm.com (1a.90.2fa9.ip4.static.sl-reverse.com [169.47.144.26]) by mx0a-001b2d01.pphosted.com with ESMTP id 35kuqx8c90-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 22 Dec 2020 20:11:20 -0500 Received: from pps.filterd (ppma04wdc.us.ibm.com [127.0.0.1]) by ppma04wdc.us.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 0BN12Msh011495; Wed, 23 Dec 2020 01:11:19 GMT Received: from b03cxnp07028.gho.boulder.ibm.com (b03cxnp07028.gho.boulder.ibm.com [9.17.130.15]) by ppma04wdc.us.ibm.com with ESMTP id 35k7wbf4y2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 23 Dec 2020 01:11:19 +0000 Received: from b03ledav005.gho.boulder.ibm.com (b03ledav005.gho.boulder.ibm.com [9.17.130.236]) by b03cxnp07028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 0BN1BIPq27197918 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 23 Dec 2020 01:11:18 GMT Received: from b03ledav005.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 59880BE054; Wed, 23 Dec 2020 01:11:18 +0000 (GMT) Received: from b03ledav005.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8D504BE056; Wed, 23 Dec 2020 01:11:10 +0000 (GMT) Received: from manicouagan.localdomain (unknown [9.80.219.136]) by b03ledav005.gho.boulder.ibm.com (Postfix) with ESMTPS; Wed, 23 Dec 2020 01:11:10 +0000 (GMT) References: <20201219175713.18888-1-nramas@linux.microsoft.com> <20201219175713.18888-6-nramas@linux.microsoft.com> User-agent: mu4e 1.4.10; emacs 27.1 From: Thiago Jung Bauermann To: Lakshmi Ramasubramanian Cc: zohar@linux.ibm.com, robh@kernel.org, takahiro.akashi@linaro.org, gregkh@linuxfoundation.org, will@kernel.org, catalin.marinas@arm.com, mpe@ellerman.id.au, james.morse@arm.com, sashal@kernel.org, benh@kernel.crashing.org, paulus@samba.org, frowand.list@gmail.com, vincenzo.frascino@arm.com, mark.rutland@arm.com, dmitry.kasatkin@gmail.com, jmorris@namei.org, serge@hallyn.com, pasha.tatashin@soleen.com, allison@lohutok.net, masahiroy@kernel.org, bhsharma@redhat.com, mbrugger@suse.com, hsinyi@chromium.org, tao.li@vivo.com, christophe.leroy@c-s.fr, prsriva@linux.microsoft.com, balajib@linux.microsoft.com, linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org Subject: Re: [PATCH v13 5/6] arm64: Free DTB buffer if fdt_open_into() fails In-reply-to: <20201219175713.18888-6-nramas@linux.microsoft.com> Date: Tue, 22 Dec 2020 22:11:08 -0300 Message-ID: <87wnx9jphv.fsf@manicouagan.localdomain> MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.343,18.0.737 definitions=2020-12-22_13:2020-12-21,2020-12-22 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 adultscore=0 bulkscore=0 clxscore=1015 mlxscore=0 suspectscore=0 phishscore=0 priorityscore=1501 lowpriorityscore=0 spamscore=0 impostorscore=0 mlxlogscore=747 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2012230003 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Lakshmi Ramasubramanian writes: > create_dtb() function allocates memory for the device tree blob (DTB) > and calls fdt_open_into(). If this call fails the memory allocated > for the DTB is not freed before returning from create_dtb() thereby > leaking memory. > > Call vfree() to free the memory allocated for the DTB if fdt_open_into() > fails. > > Co-developed-by: Prakhar Srivastava > Signed-off-by: Prakhar Srivastava > Signed-off-by: Lakshmi Ramasubramanian > --- > arch/arm64/kernel/machine_kexec_file.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Reviewed-by: Thiago Jung Bauermann -- Thiago Jung Bauermann IBM Linux Technology Center