Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp5458420pxu; Tue, 22 Dec 2020 18:41:05 -0800 (PST) X-Google-Smtp-Source: ABdhPJxa5abJvrH4zd+B4mjq/UlBWzF0AFkmt+Jea7ra7+c8VyJoJayu72riT3MLq8k0CCC3QTxv X-Received: by 2002:a17:906:9345:: with SMTP id p5mr22045251ejw.40.1608691265653; Tue, 22 Dec 2020 18:41:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1608691265; cv=none; d=google.com; s=arc-20160816; b=DEj9yTBu0+WxylVEMsy8fRWKTSeYpqzvxex6fSARnPTWV3lGGKjC1Iykn5T4kQA7lA riqazH4X01RbZHiRE5lb/1yXcut1EtVWTNI8u57a0e1vTDCHq209PM9mfLeGQc7eb2Ps iqA4wJWeG+9D51z1HwctaPTMlqF5qxyIRDXXK+QTY+EyFByWGaPiRD0DNgDeIFSPCHri WqS3w+V1SUMR4XZ+XfeSTuf7a/cOdN4BIC2sIg+V4Vmdt0Bsg+5QfqhPB6zijFXIKi8y PixObSBqfeLhHDZAPLBEG+Ghce3WSuaTqeRPfxVrQeA9BU51n5mQBeYn0uUQbOVlQKtu Cpqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=/xsDTL3VFen9xcOywNuEH1p85h9CeW4aI6QJimczZ6U=; b=HpEC1nJQWLvsvtxbdggK3QgamWlHTS4FVi+nE3vjFTG0qLVq68uRDrXmmX9y4aB15V gltqhEx0ZbJqbbxg4ZaG93OT4HSS5Xtv0U43T/ewtsSMN5auvyS0riGv8/HjZM9A3kv8 h7OnzQMlbRjZZkDfbOqOQKJVwBvMwHv5QjgNiuRak/YZb5ZDM7PpXbVJOWzFjT79ds3a 7TsPUdsnDNpkk7SM8/gNjLH9E31PydmsRzC2Y0Lh4he3ZwdY5xfOUHpAckzp0tH+a4tr KE4OqMaWzMJYFsjmHAQEH/kXIRehll1bS2coD8B0g+PBB13rpX2AjY1UV0QYT110BdOk 0zqg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=FW7RSMKp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y11si14220448edm.309.2020.12.22.18.40.43; Tue, 22 Dec 2020 18:41:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=FW7RSMKp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730918AbgLWCkk (ORCPT + 99 others); Tue, 22 Dec 2020 21:40:40 -0500 Received: from mail.kernel.org ([198.145.29.99]:51318 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730030AbgLWCXg (ORCPT ); Tue, 22 Dec 2020 21:23:36 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0992E2256F; Wed, 23 Dec 2020 02:23:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1608690196; bh=3ZACMQIcQWnmZL9ULyup2SrmOjvIT27EZp63RBPbbSc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FW7RSMKp+isKfpfJ0jsyZsOY250/gnXm7VOZxUd/8RkpZT9NSxeFJCIXc+ZB8gxeo 3uNw5MJpcX/HanCte0rgCPZHv9stQsmqTHbHtwse0+v9Z0Dh84hviIFlDplCwTJtkR sWjr/1abZL1GFAW+844NnO01sJFg1CBlt4UJARfDzWl8zufEfMX7mZn2SC68XsL9Cw HjO2KOyiIDuBJ5I4Bzj29t1Lmg8EqpdVvDkZn5S2a52rcs2Vq71VZXQlIhUtNKcB7n PmUojtJlJ05/in0u4qoXl/vCerwo69bXRV09kz4la7XCn/FzsyBVM6nMnjWPDV8jby yxfce1tS5fbNg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Necip Fazil Yildiran , Thomas Bogendoerfer , Sasha Levin , linux-mips@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 19/66] MIPS: BMC47xx: fix kconfig dependency bug for BCM47XX_SSB Date: Tue, 22 Dec 2020 21:22:05 -0500 Message-Id: <20201223022253.2793452-19-sashal@kernel.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20201223022253.2793452-1-sashal@kernel.org> References: <20201223022253.2793452-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Necip Fazil Yildiran [ Upstream commit 09a48cbcd7af9203296938044f1100bb113ce01a ] When BCM47XX_SSB is enabled and SSB_PCIHOST is disabled, it results in the following Kbuild warning: WARNING: unmet direct dependencies detected for SSB_B43_PCI_BRIDGE Depends on [n]: SSB [=y] && SSB_PCIHOST [=n] Selected by [y]: - BCM47XX_SSB [=y] && BCM47XX [=y] && PCI [=y] The reason is that BCM47XX_SSB selects SSB_B43_PCI_BRIDGE without depending on or selecting SSB_PCIHOST while SSB_B43_PCI_BRIDGE depends on SSB_PCIHOST. This can also fail building the kernel as demonstrated in a bug report. Honor the kconfig dependency to remove unmet direct dependency warnings and avoid any potential build failures. Link: https://bugzilla.kernel.org/show_bug.cgi?id=210051 Signed-off-by: Necip Fazil Yildiran Signed-off-by: Thomas Bogendoerfer Signed-off-by: Sasha Levin --- arch/mips/bcm47xx/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/mips/bcm47xx/Kconfig b/arch/mips/bcm47xx/Kconfig index 29471038d817e..54e79f3047a14 100644 --- a/arch/mips/bcm47xx/Kconfig +++ b/arch/mips/bcm47xx/Kconfig @@ -9,6 +9,7 @@ config BCM47XX_SSB select SSB_DRIVER_MIPS select SSB_DRIVER_EXTIF select SSB_EMBEDDED + select SSB_PCIHOST if PCI select SSB_B43_PCI_BRIDGE if PCI select SSB_DRIVER_PCICORE if PCI select SSB_PCICORE_HOSTMODE if PCI -- 2.27.0