Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp5468048pxu; Tue, 22 Dec 2020 19:03:54 -0800 (PST) X-Google-Smtp-Source: ABdhPJxp3mHeWU8LiGahunZ4ymxXpkH81ljsXfQPc+xXvQBOmUHky8JtwlSY1961q6MlmZ3nx4VI X-Received: by 2002:a17:907:105e:: with SMTP id oy30mr22185626ejb.495.1608692634578; Tue, 22 Dec 2020 19:03:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1608692634; cv=none; d=google.com; s=arc-20160816; b=sbJQ6znsfQdbydqfqDno/JzS7mPmdjtY76A4PppQ3WrOU/7KuNi0NO0QL+9eu3uwax qRI8a5O4WbQl0icRd+Zn0Ms0ehNI+DaY+eCcNSNgVA1rV97CRF+KX4TVcNUB4iEGm62Q 1TmXlY9hryzFR+rDE7b5l4w28Ctp8TwNsf+iXLRqNPSf4DDeEkis8AgHAj4LXVMG9lAs NCVWcDBk+wCB+KL9XAXuwKliQcruNTLsZIotwsji5W79UfzbY4EeD+wi/6fITRlAhsuY sBhMJ8uVHoA2KXopy+LEu2T3UWsM8Rg/hmkAwuRE0VG8zjbs9Nxk1WYbnR8CBn+gJxeO pE1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=mPwyHYZQw4k4Hx8V5/2+oGcW/fvz7bhIWpZkFjZbiNU=; b=kGMMlnHeGO8Tlv1c9/ZkpqJlyf9Uy7aIvafdNOpBo6cnKcv9nnBBvybie7BNHkKtq2 2UhtaGJ2+YChg51C01HVsc6Q4HQCQgsaLaYPNIlAMzLMI0EBtEjyN0so7BcU8UvTn1Ov qqo3flZlhbE5Tv5vC8WNsQIsCEDsSfR7pgFNW5epm79h1iIAIEIl26pg1ki08xhfJVRY tZ0A3w68pjtl+NrHoo9CfwjFGanTJPCA0ygJwGQu2CzpeOnSZ89TkZJGofivrJ0GX4eT 1z9hjW8pq7WYWRECelLYOCpmrDRLFvHsnyPIzhNXRTSygnxZLLMechr3jpiGnaNPYMSQ TTKQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=XFBDN77V; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r22si11793426eji.295.2020.12.22.19.03.32; Tue, 22 Dec 2020 19:03:54 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=XFBDN77V; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728812AbgLWCTz (ORCPT + 99 others); Tue, 22 Dec 2020 21:19:55 -0500 Received: from mail.kernel.org ([198.145.29.99]:46328 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728684AbgLWCTg (ORCPT ); Tue, 22 Dec 2020 21:19:36 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8E331225AA; Wed, 23 Dec 2020 02:19:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1608689943; bh=y4SClHplxMoNfmDVqbnedSr667czje45z1pHwNh970w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XFBDN77Vv6pH65Q0gniOU/IoqnbzhROgkXq/P+4RlAjwocxq1SmStfvRd0bKKniRm QbS9VbvGaJ+aeBh5KHxNNn98q+ogz56ZxIncDJ7L+maRYVytYVIa99aqRwiGelPlGa Rx9S7e4hbt93+7SA3crA0yhfB2DwS+mg7hZDp/Ugo0TYnu4dYnRW54aGr+sf11QMvc hgSoa/1Ezb/ckiAfDkoa8hD+7cNy2ogMj4vLLXcQJO1tcRVup76vkHy7GP9Mec17LY KvosdLHxXq9qLBi6Tp4xH5tJk/gdpMKEz042SeSeyFyPFUCPx4HWiV5kCVLjFTJOjl O+WcVSF43qFyw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Hans Verkuil , Mauro Carvalho Chehab , Sasha Levin , linux-media@vger.kernel.org Subject: [PATCH AUTOSEL 5.4 038/130] media: cec-core: first mark device unregistered, then wake up fhs Date: Tue, 22 Dec 2020 21:16:41 -0500 Message-Id: <20201223021813.2791612-38-sashal@kernel.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20201223021813.2791612-1-sashal@kernel.org> References: <20201223021813.2791612-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Hans Verkuil [ Upstream commit e91c255733d9bbb4978a372f44fb5ed689ccdbd1 ] If a CEC device node is unregistered, then it should be marked as unregistered before waking up any filehandles that are waiting for an event. This ensures that there is no race condition where an application can call CEC_DQEVENT and have the ioctl return 0 instead of ENODEV. Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/cec/cec-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/cec/cec-core.c b/drivers/media/cec/cec-core.c index 9c610e1e99b84..76b78fb627e83 100644 --- a/drivers/media/cec/cec-core.c +++ b/drivers/media/cec/cec-core.c @@ -166,12 +166,12 @@ static void cec_devnode_unregister(struct cec_adapter *adap) mutex_unlock(&devnode->lock); return; } + devnode->registered = false; + devnode->unregistered = true; list_for_each_entry(fh, &devnode->fhs, list) wake_up_interruptible(&fh->wait); - devnode->registered = false; - devnode->unregistered = true; mutex_unlock(&devnode->lock); mutex_lock(&adap->lock); -- 2.27.0