Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030257AbWIETNH (ORCPT ); Tue, 5 Sep 2006 15:13:07 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030258AbWIETNH (ORCPT ); Tue, 5 Sep 2006 15:13:07 -0400 Received: from cantor2.suse.de ([195.135.220.15]:8399 "EHLO mx2.suse.de") by vger.kernel.org with ESMTP id S1030257AbWIETNG (ORCPT ); Tue, 5 Sep 2006 15:13:06 -0400 Date: Tue, 5 Sep 2006 12:12:41 -0700 From: Greg KH To: Pierre Ossman Cc: Andrew Morton , Alex Dubov , linux-kernel@vger.kernel.org Subject: Re: Support for TI FlashMedia (pci id 104c:8033, 104c:803b) flash card readers Message-ID: <20060905191241.GA18427@kroah.com> References: <20060902085343.93521.qmail@web36708.mail.mud.yahoo.com> <44F967E8.9020503@drzeus.cx> <20060902094818.49e5e1b1.akpm@osdl.org> <44F9EE86.4020500@drzeus.cx> <20060903034836.GB6505@kroah.com> <44FAA61F.9000504@drzeus.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <44FAA61F.9000504@drzeus.cx> User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1964 Lines: 52 On Sun, Sep 03, 2006 at 11:53:35AM +0200, Pierre Ossman wrote: > Greg KH wrote: > > On Sat, Sep 02, 2006 at 10:50:14PM +0200, Pierre Ossman wrote: > > > >> > >> This is a PCI device yes. Which has a number of card readers as > >> separate, hot-pluggable functions. Currently this means it interacts > >> with the block device and MMC subsystems of the kernel. As more drivers > >> pop up, the other card formats will probably get their own subsystems > >> the way MMC has. So there are three issues here: > >> > >> * Where to put the central module that handles the generic parts of the > >> chip and pulls in the other modules as needed. > >> > > > > Right now, the drivers/mmc directory has such a driver, the sdhci.c > > file, right? > > > > > > Not quite. sdhci is a vendor-neutral MMC controller driver. What I'm > talking about here is the interface-neutral portion for the Texas > Instruments multi-format card reader. > > >> * If the subfunction modules should be put with the subsystems they > >> connect to or with the main, generic module. > >> > > > > It all depends on how bit it grows over time. It is always easy to move > > files around at a later time if you so wish. > > > > For now, is the drivers/mmc/ directory acceptable? If other card > > formats show up, we can reconsider it at that time. Is that ok? > > > > Support for MemoryStick isn't that far off in the future, so it would be > preferable to get this right from the start. > > Is there no driver in the kernel that already has this design? Not directly, no. USB-storage handles a wide range of devices like this by virtue of them following the usb storage spec (which is really just scsi). thanks, greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/