Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp5593330pxu; Tue, 22 Dec 2020 23:51:35 -0800 (PST) X-Google-Smtp-Source: ABdhPJwIS45DMLQqanmgVpngfyQbfeTJXeB+Gq907EKhQBRQzqlaM3oSDEB8Lmrs4x8QumrItoXd X-Received: by 2002:a17:906:7090:: with SMTP id b16mr23595490ejk.76.1608709895115; Tue, 22 Dec 2020 23:51:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1608709895; cv=none; d=google.com; s=arc-20160816; b=wOD20hRIX5QEo15GEHV4dW11u1MmFrgWLLTGVnaqyINvrppCKiUn9365OCeUH4/ORO FM7aa973Tj/tj+pHXBwXF/da55vY+Q0kEtNorj0FC1LVnBdvNB0f/SiPFEZAu9h7ZGFe Xkpw1d0wGmtCMYkdgsgyxmVdN817pbE+bX1Z/AV9OKiICygaX5mrtzXt2X8cH4Wz4qgO 1X2ozbYF5MryXIgMEgXnIvwGczkoagBjZNgn7Q44ZGH8th6NVqvAxubMxgiZG6wG/0iF 28iAptRe2TvFABpxBqYio/cKQLldkSskUa10+EM0OlSUiB/aREMSJ3vZiM5pqUB4T1YD Rn2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from; bh=3F5eYBKsaK3dHseYinE55GiZ6ppRmt1ksQCrTUMf5jk=; b=qC3BPFF+lW4MGj1+EJs3vvzqNvjZn1IyvOKk8hKDpyCS3S2ldQNYDWHLGr69HykV82 uT4W19026g7c9NcaoRpNBY6vsLXPIb/aR4SwpbPYPl8fq3n3ysIZr/vbeqwAzO3j98ox JgBJ7DVxAN8Cvoo2Xs4AyucdkidqE9PpV0JnjgIxxdqm0ersJ1QZDAk5cTu36IyhrFUV OPvyaRGU1EgFrOt15HuOMce5zkmeKPZv4t3KLT37uMAkcIOR3M++5ROtbcf9N1WhzFDs quUv9z6QNWh4hhCAZkMctyjVsC29GOXhqumrVyF/GF5ckYFN41MBBAVYBBaCCGElC2A/ 5eWw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mediatek.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p16si11837621ejo.364.2020.12.22.23.51.13; Tue, 22 Dec 2020 23:51:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mediatek.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727823AbgLWHt7 (ORCPT + 99 others); Wed, 23 Dec 2020 02:49:59 -0500 Received: from mailgw01.mediatek.com ([210.61.82.183]:39247 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1727063AbgLWHt6 (ORCPT ); Wed, 23 Dec 2020 02:49:58 -0500 X-UUID: f1eb7a0b826f48c39453b49c5c9ef7ea-20201223 X-UUID: f1eb7a0b826f48c39453b49c5c9ef7ea-20201223 Received: from mtkcas10.mediatek.inc [(172.21.101.39)] by mailgw01.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.14 Build 0819 with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 164922422; Wed, 23 Dec 2020 15:49:12 +0800 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkmbs07n1.mediatek.inc (172.21.101.16) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 23 Dec 2020 15:48:48 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 23 Dec 2020 15:48:49 +0800 From: Michael Kao To: , , Zhang Rui , Daniel Lezcano , , CC: Eduardo Valentin , Rob Herring , Mark Rutland , Matthias Brugger , , , , , , brian-sy yang Subject: [PATCH] thermal: cpufreq_cooling: fix slab OOB issue Date: Wed, 23 Dec 2020 15:48:49 +0800 Message-ID: <20201223074849.1989-1-michael.kao@mediatek.com> X-Mailer: git-send-email 2.18.0 MIME-Version: 1.0 Content-Type: text/plain X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: brian-sy yang Slab OOB issue is scanned by KASAN in cpu_power_to_freq(). If power is limited below the power of OPP0 in EM table, it will cause slab out-of-bound issue with negative array index. Return the lowest frequency if limited power cannot found a suitable OPP in EM table to fix this issue. Backtrace: [] die+0x104/0x5ac [] bug_handler+0x64/0xd0 [] brk_handler+0x160/0x258 [] do_debug_exception+0x248/0x3f0 [] el1_dbg+0x14/0xbc [] __kasan_report+0x1dc/0x1e0 [] kasan_report+0x10/0x20 [] __asan_report_load8_noabort+0x18/0x28 [] cpufreq_power2state+0x180/0x43c [] power_actor_set_power+0x114/0x1d4 [] allocate_power+0xaec/0xde0 [] power_allocator_throttle+0x3ec/0x5a4 [] handle_thermal_trip+0x160/0x294 [] thermal_zone_device_check+0xe4/0x154 [] process_one_work+0x5e4/0xe28 [] worker_thread+0xa4c/0xfac [] kthread+0x33c/0x358 [] ret_from_fork+0xc/0x18 Signed-off-by: brian-sy yang --- drivers/thermal/cpufreq_cooling.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/thermal/cpufreq_cooling.c b/drivers/thermal/cpufreq_cooling.c index cc2959f22f01..fb33b3480a8f 100644 --- a/drivers/thermal/cpufreq_cooling.c +++ b/drivers/thermal/cpufreq_cooling.c @@ -123,7 +123,7 @@ static u32 cpu_power_to_freq(struct cpufreq_cooling_device *cpufreq_cdev, { int i; - for (i = cpufreq_cdev->max_level; i >= 0; i--) { + for (i = cpufreq_cdev->max_level; i > 0; i--) { if (power >= cpufreq_cdev->em->table[i].power) break; } -- 2.18.0