Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp5690356pxu; Wed, 23 Dec 2020 03:03:31 -0800 (PST) X-Google-Smtp-Source: ABdhPJwEiGan6l4JdoPek6BImrwjqDRgjHPCMxTXInJmkSHSULZ32bkgJk+y2BRXr+MZTbv/YM1L X-Received: by 2002:aa7:d75a:: with SMTP id a26mr23529525eds.230.1608721410932; Wed, 23 Dec 2020 03:03:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1608721410; cv=none; d=google.com; s=arc-20160816; b=WrZxe+LKdVYtZaQsxjs3T9Sos2+7lJJZcQHcwZC6WoeQlpdlN6xzizDXHK/HaqWgWW sxWbnvg4SySxwkw/iZkJMB99VocA7nPT3+BoWb5iCxLMGuEetFtR+kToA16fBJgMSBAW oGzWFkJRf+dhK/Pgw+xxoI5D8nOKI4MmCSGJ+a/7UqFBYzLCnzepDgDyoJaYmSKjs0hs gaGwfZjoLi1y3ayU+NVnW4WhQBIPGjccopAVLmWVwfWn6l+yvnB6aDi0dxU+4d05W5Y1 1pqVUkpYjWrwqV33aT13s+2UUMG9foIGmEMtnGUTt6Z78g2SkA9bda3r6hXA2ablEAG4 w4QA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=M35LHELfTDr+95tytg/ZBbWoj5oyIhKQQ5Gnw2hDcsQ=; b=NPH2Jl9lazvSiLHLufmUdyWRF6ViMEdUbv2jEq4HjoKT2S3xJkd1TI8iSIyD8i2ZAv qxx2U4ewUL1U4PY4BVvel0VouHP+ktR7QprReZpovhn08kgb+u5lwQjlWdgfPPaTPdXh YjXJdnbve4k/fbXClB+Oc5uiPTY2iqGoh1y2lhI82SQWRinU2+OfWt2eycU6abc/UrP1 T+Uy6zK01hiREbeoRLLXG01wLlS/R7pq5HuzME1wsQlWh8pSsgf0qJT9V6h8xhBjCec2 xLCnr/sArl6U6FhKiezuSQlhP/I2uMZLo7chD4bytMiCOMz+IZfiY6CkflieC9V833kW xLgg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=SLWB4RWK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f8si11639348ejr.517.2020.12.23.03.03.08; Wed, 23 Dec 2020 03:03:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=SLWB4RWK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728362AbgLWLBh (ORCPT + 99 others); Wed, 23 Dec 2020 06:01:37 -0500 Received: from m12-18.163.com ([220.181.12.18]:49909 "EHLO m12-18.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728214AbgLWLBh (ORCPT ); Wed, 23 Dec 2020 06:01:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=Date:From:Subject:Message-ID:MIME-Version; bh=M35LH ELfTDr+95tytg/ZBbWoj5oyIhKQQ5Gnw2hDcsQ=; b=SLWB4RWKdTfsfCRzKt1Yn weMXlV9BoCZLuuv9AeVO0n5n869bGL55CfyWFeuxBPP3BqJwJePOHg6eb5wqd1FU 7vZ6GB1qON11WqiT4mULktW3eksaSFN42ePl4kODArdbzGz7KlpQZnEgyflQHz28 WLvtZAs527wAigXyJx4Kzg= Received: from localhost (unknown [101.86.213.121]) by smtp14 (Coremail) with SMTP id EsCowAAn34LfDONfEs8NLQ--.30515S2; Wed, 23 Dec 2020 17:24:48 +0800 (CST) Date: Wed, 23 Dec 2020 17:24:47 +0800 From: Hui Su To: Christoph Hellwig Cc: Jens Axboe , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, songmuchun@bytedance.com, sh_def@163.com Subject: Re: [PATCH] blokc/blk-merge: remove the next_bvec label in __blk_bios_map_sg()linux-block@vger.kernel.org (open list:BLOCK LAYER) Message-ID: <20201223092447.GA1558053@ubuntu-A520I-AC> References: <20201223043158.GA1502002@ubuntu-A520I-AC> <20201223083307.GA27350@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201223083307.GA27350@infradead.org> X-CM-TRANSID: EsCowAAn34LfDONfEs8NLQ--.30515S2 X-Coremail-Antispam: 1Uf129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7v73 VFW2AGmfu7bjvjm3AaLaJ3UbIYCTnIWIevJa73UjIFyTuYvj4iLL0DUUUUU X-Originating-IP: [101.86.213.121] X-CM-SenderInfo: xvkbvvri6rljoofrz/xtbBDgAEX1rbLpibAQAAs4 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 23, 2020 at 08:33:07AM +0000, Christoph Hellwig wrote: > On Wed, Dec 23, 2020 at 12:31:58PM +0800, sh wrote: > > remove the next_bvec label in __blk_bios_map_sg(), simplify the logic > > of traversal bvec. > > What makes you believe that this simplifies anything? 1. this change remove the jump lable, so we do not need goto. 2. we do not need to assign flase to new_bio in the bio_for_each_bvec, we only need to assign false to new_bio at first. And I have resend a PATCH V2, this change have some format problem. Thanks.