Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH phy] PHY: Ingenic: fix unconditional build of
 phy-ingenic-usb
To:     Alexander Lobakin <alobakin@pm.me>,
        Kishon Vijay Abraham I <kishon@ti.com>,
        Vinod Koul <vkoul@kernel.org>
Cc:     =?UTF-8?B?5ryG6bmP5oyv?= <aric.pzqi@ingenic.com>,
        Paul Cercueil <paul@crapouillou.net>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        linux-kernel@vger.kernel.org
References: <20201222131021.4751-1-alobakin@pm.me>
From:   Zhou Yanjie <zhouyanjie@wanyeetech.com>
Message-ID: <8b34319d-b085-853a-c2f8-384bd60f50ff@wanyeetech.com>
Date:   Wed, 23 Dec 2020 22:18:07 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.9.0
MIME-Version: 1.0
In-Reply-To: <20201222131021.4751-1-alobakin@pm.me>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Precedence: bulk

Hi Alexander,

On 2020/12/22 下午9:10, Alexander Lobakin wrote:
> Currently drivers/phy/ingenic/Makefile adds phy-ingenic-usb to targets
> not depending on actual Kconfig symbol CONFIG_PHY_INGENIC_USB, so this
> driver always gets built[-in] on every system.
> Add missing dependency.
>
> Fixes: 31de313dfdcf ("PHY: Ingenic: Add USB PHY driver using generic PHY framework.")
> Signed-off-by: Alexander Lobakin <alobakin@pm.me>
> ---
>   drivers/phy/ingenic/Makefile | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)


Apologize for my carelessness, and

Tested-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com>


Thanks and best regards!


> diff --git a/drivers/phy/ingenic/Makefile b/drivers/phy/ingenic/Makefile
> index 65d5ea00fc9d..1cb158d7233f 100644
> --- a/drivers/phy/ingenic/Makefile
> +++ b/drivers/phy/ingenic/Makefile
> @@ -1,2 +1,2 @@
>   # SPDX-License-Identifier: GPL-2.0
> -obj-y		+= phy-ingenic-usb.o
> +obj-$(CONFIG_PHY_INGENIC_USB)		+= phy-ingenic-usb.o