Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp5888304pxu; Wed, 23 Dec 2020 07:54:02 -0800 (PST) X-Google-Smtp-Source: ABdhPJy/kkr7VPW/EjXSVvu7OGsHDke0Srl0p96KorMQqgZdU+Sxy5mXvDgJ6NsZeaaytLMpcJlY X-Received: by 2002:a17:906:85cd:: with SMTP id i13mr24678126ejy.553.1608738842138; Wed, 23 Dec 2020 07:54:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1608738842; cv=none; d=google.com; s=arc-20160816; b=Qut2WrBZNXhveXxwUcOKm0QUv0bSosTddrP1pslEMhKRN09+Lbz+6/VDm/569V6nsc tQThdCZfa8ce3+R2n2J5aQ47oRoRbPtxf2kuRFefjdXxJ3F8/acbpjQsomx78BulX9hy S6ubd1dkBGwZc8F+1ZvxrkPKzfyfHn1jeBgairrC6Zcbwexb8+N9telo1LEY8pg6LoEO f2Hx5+EYPdmzfB+L16RB5i414gni9QLn9jzEftWox2vOfIruNJY8+ku36xymldiRu0lL LPv6PUkLRtFmK0cvvo8O3Y5D9RsACPWuxb9M6YUA/LL3CQeJVrXBfhDHImSqGtq4FAHJ Gw2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=DvH0NyUD3VzfHuiFkeAq1PYtCpt4Xs2NiwNXDYcFb5E=; b=u6AFKg5N4W+Z+MUdEnyLSOz6SWAWfJRJF2bc5mXdSiWMwM+T97YS8RlYT0F4Poyru6 bYfOG+fU/S4RrUnqzlJ5OuVzHE0Ng2JcSVYXn9oMx+w5EAAIahu/uEOpJM+NkS5wVHc1 Py/xuBoKA6EKLSmGIwP5XG1yoVAeSq2mafQTSmpbxBL1p5FKJU7xqXsu7ffw61pCRfxz dzwyUbz4oioeVDzpKQRZ75PLuNK+AIZvWL27nmUxnJAJXWqkNXa2EudvI1uu0XpyA4pi DxojzLRrecePGqC5DEiWi7JxwBjGob5QlxHaHsSrYB160I1mnu3fQWSxLNnl05VodJ7Y pD3g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=r5Av1aYE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id co12si13049919edb.534.2020.12.23.07.53.38; Wed, 23 Dec 2020 07:54:02 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=r5Av1aYE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729063AbgLWPwb (ORCPT + 99 others); Wed, 23 Dec 2020 10:52:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47656 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726390AbgLWPwa (ORCPT ); Wed, 23 Dec 2020 10:52:30 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B2CFC06179C; Wed, 23 Dec 2020 07:51:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=DvH0NyUD3VzfHuiFkeAq1PYtCpt4Xs2NiwNXDYcFb5E=; b=r5Av1aYEpmlsqfXcI87HZwooYp hNoYZTPHlzpf8R3PngDBkeUYyekmPZHjSvP+5Y3t/QDQeOb7PjtU60bOreHBspxZd8YUySWfx6LXs Jc2J9cL/2SNWMnDDg0JGyL1dbeq6bwFLoAYSIkWYQpYYDrcyBWd1k7ay5dhh6Ajknf6vcfWMobB4M d7YDf4C3uW5cb8WAsCp1mdzQnIS5cXmqbZK92BQ+Gkc1Nn7tDAmwqTDjrN+pMSjzMJ8ia/7RQBNPY TuwEJMOQDeNP7zK1fBQ2omM4imubJcd/XoiZyc13i9XFXRjtUoP5Advk/4h1hgU32RFuK0kJecodo rkLAE63g==; Received: from hch by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1ks6QT-0001ad-OM; Wed, 23 Dec 2020 15:51:45 +0000 Date: Wed, 23 Dec 2020 15:51:45 +0000 From: Christoph Hellwig To: Pavel Begunkov Cc: Christoph Hellwig , Ming Lei , linux-block@vger.kernel.org, Jens Axboe , Matthew Wilcox , Johannes Weiner , Alexander Viro , "Darrick J . Wong" , "Martin K . Petersen" , Jonathan Corbet , linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, io-uring@vger.kernel.org, linux-kernel@vger.kernel.org, target-devel@vger.kernel.org, linux-scsi@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH v1 0/6] no-copy bvec Message-ID: <20201223155145.GA5902@infradead.org> References: <20201215014114.GA1777020@T590> <103235c1-e7d0-0b55-65d0-013d1a09304e@gmail.com> <20201215120357.GA1798021@T590> <20201222141112.GE13079@infradead.org> <933030f0-e428-18fd-4668-68db4f14b976@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <933030f0-e428-18fd-4668-68db4f14b976@gmail.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 23, 2020 at 12:52:59PM +0000, Pavel Begunkov wrote: > Can scatterlist have 0-len entries? Those are directly translated into > bvecs, e.g. in nvme/target/io-cmd-file.c and target/target_core_file.c. > I've audited most of others by this moment, they're fine. For block layer SGLs we should never see them, and for nvme neither. I think the same is true for the SCSI target code, but please double check.