Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp6013053pxu; Wed, 23 Dec 2020 10:58:18 -0800 (PST) X-Google-Smtp-Source: ABdhPJy60YdZQp67MbHJXKYBTwEWDfftgX5DF9ur4x9/tyCwIdxcR17lcf55xmW4WQtnFlAt/9we X-Received: by 2002:a17:906:1288:: with SMTP id k8mr236424ejb.206.1608749898006; Wed, 23 Dec 2020 10:58:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1608749898; cv=none; d=google.com; s=arc-20160816; b=ko2o/8Q3RvPVRTdebPt0U7bFZhekJjlr1g0YqfLCp5U4IlBYFRuI4D1czD7OaMNyb4 0qJ/x3x82ToyTFqSLTTm1QZZM4un/uE/rV2ZlraMUpHWifLauidH2e1vciEnOa9CynEL p6HUJWxo9MWB2s5wg5KX02KrhuFC3hUaL4fVvLo32pJ6eDd9u/5BFVTN+3jiJlm8ET+V 04LGUOe/DIPH0J3EoOKtdgaiGuS3y+KtW5xT3CMWrYHRfvkqi2mZUvcT+TsCVTC+DPBz XQfTpcY4tjOrqh5OV+iBfBP38G5s1/FoBy8rLKNAt16ugMpHeysWv0GqKWzITa7dVTFl NqKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=8jQ8TvAnsIxDbptywrLeuoJWSkK3iD3Et9L2f3gXwKM=; b=fGVd8qeH1NSX6MkAVQoVrOzAZDAbkqvxa69SN/2DOH6okFZpeZ0RPxUhqjR+blT90j z7d1bWJYVPQBWthXUMgNQDY2a0GYCXlIGR+mAtDRGG8QP7xFQjHY5KfpmeJ6K7HTCsn4 ciMwtgkwS0swLwFyKIRm09n4SimSi8xTTl7uEwaG7xmrepQRw0fh/1civ5vdm7xIZbTe IDyk86/G9BlPyba1ErC7gf5xJePzGWAZZ8JeuYVVrGYH9Xe4IzrBr4AMpr01pO6GBV0R mSWL+f3F7DkrV+1TA636f4WDwuVH1REMFenfPvyghVM/EW108npe2UF5H/UFUpZsV+fv anWQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=iauYCAMX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z27si14837544edl.135.2020.12.23.10.57.55; Wed, 23 Dec 2020 10:58:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=iauYCAMX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727971AbgLWS47 (ORCPT + 99 others); Wed, 23 Dec 2020 13:56:59 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:47908 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725957AbgLWS47 (ORCPT ); Wed, 23 Dec 2020 13:56:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1608749732; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8jQ8TvAnsIxDbptywrLeuoJWSkK3iD3Et9L2f3gXwKM=; b=iauYCAMXsxjxjfFrXkycPWep43M+i5YXY32NWfqn0GembtlImvZMmQ2LqbVYxha+nzY3hF Re4E+GYISzKsHOQYWv0XAcS+Ge7KH0krYyOaa9VhMemj/NWsH8hZkYLJFUp/MfFQurBb7Q 73B3mpU3JIikji76Un8qFfzoCCrPqsc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-497-7T_J0a-cPcCaOgKh-YUWgw-1; Wed, 23 Dec 2020 13:55:22 -0500 X-MC-Unique: 7T_J0a-cPcCaOgKh-YUWgw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 23C0CC29F; Wed, 23 Dec 2020 18:55:20 +0000 (UTC) Received: from mail (ovpn-112-5.rdu2.redhat.com [10.10.112.5]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4947C5D9C6; Wed, 23 Dec 2020 18:55:16 +0000 (UTC) Date: Wed, 23 Dec 2020 13:55:15 -0500 From: Andrea Arcangeli To: Peter Xu Cc: Yu Zhao , Linus Torvalds , Andy Lutomirski , Nadav Amit , linux-mm , lkml , Pavel Emelyanov , Mike Kravetz , Mike Rapoport , stable , Minchan Kim , Will Deacon , Peter Zijlstra Subject: Re: [PATCH] mm/userfaultfd: fix memory corruption due to writeprotect Message-ID: References: <20201223162416.GD6404@xz-x1> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.0.3 (2020-12-04) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 23, 2020 at 01:51:59PM -0500, Andrea Arcangeli wrote: > NOTE: about the above comment, that mprotect takes > mmap_read_lock. Your above code change in the commit above, still has ^^^^ write Correction to avoid any confusion.