Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp6042523pxu; Wed, 23 Dec 2020 11:48:25 -0800 (PST) X-Google-Smtp-Source: ABdhPJycAR57iOraru1YCL9bHhGelWn3I5FGCAXbNRKXkFnQXSgFbiGb1u/yHsPrTquOliafVll0 X-Received: by 2002:a50:ab59:: with SMTP id t25mr26054952edc.364.1608752905405; Wed, 23 Dec 2020 11:48:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1608752905; cv=none; d=google.com; s=arc-20160816; b=QVORbURGfS+NHXPGhxlae608Ib8VtSXQSCIrkRDDZE9Y1iSqamK+bsQDtz8w6HSCXj XtVrb4ps6yA88tBTHCNi2QNDpZKRa0uUEmsU+/KkpNzULS0tSbSu3RTphc1U/WhUU62v H+GtZXM4RpWrw47Wl26QMkOBsOH78fhLQJmxPiNyKIhtT2y6AYvHBS9r6eiOTQvrjG3W 9i9kaO6GrA//vHCHfnSvFGVkZBzEPprPaAjLJmRO4V5R8hQu2Q1P13LmnV0h9If9B96m W/jxuSpK4cdd4/U3qxyS7sPtW3tx1I16/NzjDcfdqmBMiIENwasQ3iNaZPkI+7GATscj CtSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=hz7m6V9y9LKYDbuYf1YRMJjX+MWq8iR3kXuzC0duUxI=; b=wEUpaXANPqa2ZcIb0fxI17/vkN/mJsAFN9FZGUc//WMpjRy38WkljcFtu2VNB1gDm0 NZOusTQxPTokoJTGusKMRnTAfaTd8ZJvoSpro16d5GGGLb5Ca+WHV/kd3NtF43X4OCJz Pjek0Qhw/y87E/ouxdQD8uc+Ih6Lnx1d+GTMpZ4zflyrZd6cdgm0UCZhf5eAaTyWDDlj euvUFHfBv23KrfT562+SMC8uvntUQq9R5nf0XuCC9ZUKlArMtm+1Jioo7B9mL6/epgzH NJhxIQ4ze49KGQlv2qvxirAYcMFubywTnoozmp3RURJpGDRRZG31CHBbl96M3wZgII5K bVhg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ixdpsCKZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id eb5si15499227edb.393.2020.12.23.11.48.02; Wed, 23 Dec 2020 11:48:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ixdpsCKZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728816AbgLWTqs (ORCPT + 99 others); Wed, 23 Dec 2020 14:46:48 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:23037 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728648AbgLWTqs (ORCPT ); Wed, 23 Dec 2020 14:46:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1608752721; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=hz7m6V9y9LKYDbuYf1YRMJjX+MWq8iR3kXuzC0duUxI=; b=ixdpsCKZTix9zGrqoVSBBDeHcnPiiTI/1x4aYP4m0nyE1TmInT557HzEA0fDc7twM2X7Gr OAoVT18NIzukeM4ZTzJKoGkZF4kJGik49PQohJy0+cHXZuMKdVvqZNeQgxYUcukq1RAIbI mL0396SdqPUwxWuD1YvgOR3Z/GiwDqQ= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-167-cZg-9Rn0NBWl0Ja6RS_AKg-1; Wed, 23 Dec 2020 14:45:19 -0500 X-MC-Unique: cZg-9Rn0NBWl0Ja6RS_AKg-1 Received: by mail-qv1-f72.google.com with SMTP id m1so211299qvp.0 for ; Wed, 23 Dec 2020 11:45:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=hz7m6V9y9LKYDbuYf1YRMJjX+MWq8iR3kXuzC0duUxI=; b=ewVyLux+AfyNeKxEw1jw5bZhOF4+ZvdHJQCN2x9wuPVzDyudposgRt/55P8nY3zg83 TrzFYSjoQR1jeoUJHho+qP0o64ztW1GOlRtcOENgLd7Sb0vc0or9+mD+aTeyc/yIt717 bUY99m9hu1Qf97EXEp8JIk2a/9DnJZlsngECmf1k0yoqnmv2rAlfNKhC1uzj+0SZS510 4gUQKjzkSSmrli9rb6iqJEHH8ar3tYKEBzv3AZf17H2beQDp9Qq4SrMwO5aFjEGISBjB WQTiO352NRKHDmUbNXabZiOXrwMV9pimckrmYjTeug1cQe74LmchVOZQhHyNyXMhlpUa Hggw== X-Gm-Message-State: AOAM533nlFKB5QZQOUmWWo9cwAZAeY9TEkUWK6qycvdnG3Y7m0gXNXti kyvHYOZyeHWQeRLsh7zwTzf7pG0jwOwPjsG1MbDos9Us1rw1+mds6S7+J9QSKaotZphgOlmvHDL HmyDoDyYM++YlCNRahGCN5E2p X-Received: by 2002:ac8:5286:: with SMTP id s6mr27092692qtn.22.1608752719378; Wed, 23 Dec 2020 11:45:19 -0800 (PST) X-Received: by 2002:ac8:5286:: with SMTP id s6mr27092678qtn.22.1608752719201; Wed, 23 Dec 2020 11:45:19 -0800 (PST) Received: from trix.remote.csb (075-142-250-213.res.spectrum.com. [75.142.250.213]) by smtp.gmail.com with ESMTPSA id u4sm14517904qtv.49.2020.12.23.11.45.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Dec 2020 11:45:18 -0800 (PST) From: trix@redhat.com To: saeedm@nvidia.com, leon@kernel.org, davem@davemloft.net, kuba@kernel.org, vladyslavt@nvidia.com, maximmi@mellanox.com, tariqt@nvidia.com, bjorn.topel@intel.com Cc: netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, Tom Rix Subject: [PATCH] net/mlx5e: remove h from printk format specifier Date: Wed, 23 Dec 2020 11:45:12 -0800 Message-Id: <20201223194512.126231-1-trix@redhat.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tom Rix This change fixes the checkpatch warning described in this commit commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of unnecessary %h[xudi] and %hh[xudi]") Standard integer promotion is already done and %hx and %hhx is useless so do not encourage the use of %hh[xudi] or %h[xudi]. Signed-off-by: Tom Rix --- drivers/net/ethernet/mellanox/mlx5/core/en/params.c | 2 +- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/params.c b/drivers/net/ethernet/mellanox/mlx5/core/en/params.c index 43271a3856ca..36381a2ed5a5 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en/params.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/params.c @@ -179,7 +179,7 @@ int mlx5e_validate_params(struct mlx5e_priv *priv, struct mlx5e_params *params) stop_room = mlx5e_calc_sq_stop_room(priv->mdev, params); if (stop_room >= sq_size) { - netdev_err(priv->netdev, "Stop room %hu is bigger than the SQ size %zu\n", + netdev_err(priv->netdev, "Stop room %u is bigger than the SQ size %zu\n", stop_room, sq_size); return -EINVAL; } diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c index 03831650f655..d41bfea85aa2 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c @@ -3763,7 +3763,7 @@ static int set_feature_lro(struct net_device *netdev, bool enable) mutex_lock(&priv->state_lock); if (enable && priv->xsk.refcnt) { - netdev_warn(netdev, "LRO is incompatible with AF_XDP (%hu XSKs are active)\n", + netdev_warn(netdev, "LRO is incompatible with AF_XDP (%u XSKs are active)\n", priv->xsk.refcnt); err = -EINVAL; goto out; @@ -4005,7 +4005,7 @@ static bool mlx5e_xsk_validate_mtu(struct net_device *netdev, max_mtu_page = mlx5e_xdp_max_mtu(new_params, &xsk); max_mtu = min(max_mtu_frame, max_mtu_page); - netdev_err(netdev, "MTU %d is too big for an XSK running on channel %hu. Try MTU <= %d\n", + netdev_err(netdev, "MTU %d is too big for an XSK running on channel %u. Try MTU <= %d\n", new_params->sw_mtu, ix, max_mtu); return false; } -- 2.27.0