Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 23 Dec 2020 13:11:49 -0800
From:   Jakub Kicinski <kuba@kernel.org>
To:     Andrew Lunn <andrew@lunn.ch>
Cc:     Dinghao Liu <dinghao.liu@zju.edu.cn>, kjlu@umn.edu,
        "David S. Miller" <davem@davemloft.net>,
        Jesse Brandeburg <jesse.brandeburg@intel.com>,
        Arnd Bergmann <arnd@arndb.de>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: ethernet: Fix memleak in ethoc_probe
Message-ID: <20201223131149.15fff8d2@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <20201223210044.GA3253993@lunn.ch>
References: <20201223110615.31389-1-dinghao.liu@zju.edu.cn>
        <20201223153304.GD3198262@lunn.ch>
        <20201223123218.1cf7d9cb@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
        <20201223210044.GA3253993@lunn.ch>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Wed, 23 Dec 2020 22:00:44 +0100 Andrew Lunn wrote:
> On Wed, Dec 23, 2020 at 12:32:18PM -0800, Jakub Kicinski wrote:
> > On Wed, 23 Dec 2020 16:33:04 +0100 Andrew Lunn wrote:  
> > > On Wed, Dec 23, 2020 at 07:06:12PM +0800, Dinghao Liu wrote:  
> > > > When mdiobus_register() fails, priv->mdio allocated
> > > > by mdiobus_alloc() has not been freed, which leads
> > > > to memleak.
> > > > 
> > > > Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>    
> > > 
> > > Fixes: bfa49cfc5262 ("net/ethoc: fix null dereference on error exit path")
> > > 
> > > Reviewed-by: Andrew Lunn <andrew@lunn.ch>  
> > 
> > Ooof, I applied without looking at your email and I added:
> > 
> > Fixes: e7f4dc3536a4 ("mdio: Move allocation of interrupts into core")  
> 
> [Goes and looks deeper]
> 
> Yes, commit e7f4dc3536a4 looks like it introduced the original
> problem. bfa49cfc5262 just moved to code around a bit.
> 
> Does patchwork not automagically add Fixes: lines from full up emails?
> That seems like a reasonable automation.

Looks like it's been a TODO for 3 years now:

https://github.com/getpatchwork/patchwork/issues/151

:(